Skip to content

Source Google Ads: upgrade google-ads package version #9996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 4, 2022
Merged

Source Google Ads: upgrade google-ads package version #9996

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b7af4fb
upgrade google-ads package version
Augan93 Feb 2, 2022
6d60391
add comment about use_proto_plus
Augan93 Feb 4, 2022
6ac6d0a
bump version
Augan93 Feb 4, 2022
ce4a8f6
updated spec and def yaml
Augan93 Feb 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-google-ads/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

from setuptools import find_packages, setup

MAIN_REQUIREMENTS = ["airbyte-cdk~=0.1", "google-ads==13.0.0", "pendulum"]
MAIN_REQUIREMENTS = ["airbyte-cdk~=0.1", "google-ads==14.1.0", "pendulum"]

TEST_REQUIREMENTS = ["pytest~=6.1", "pytest-mock"]

Expand Down
12 changes: 0 additions & 12 deletions ...yte-integrations/connectors/source-google-ads/source_google_ads/schemas/ad_group_ads.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,9 +479,6 @@
"type": "string"
}
},
"ad_group_ad.ad.video_ad.bumper.companion_banner": {
"type": ["null", "string"]
},
"ad_group_ad.ad.video_ad.discovery.description1": {
"type": ["null", "string"]
},
Expand All @@ -497,15 +494,6 @@
"ad_group_ad.ad.video_ad.in_stream.action_headline": {
"type": ["null", "string"]
},
"ad_group_ad.ad.video_ad.in_stream.companion_banner": {
"type": ["null", "string"]
},
"ad_group_ad.ad.video_ad.media_file": {
"type": ["null", "string"]
},
"ad_group_ad.ad.video_ad.non_skippable.companion_banner": {
"type": ["null", "string"]
},
"ad_group_ad.ad.video_ad.out_stream.description": {
"type": ["null", "string"]
},
Expand Down
3 changes: 3 additions & 0 deletions airbyte-integrations/connectors/source-google-ads/source_google_ads/source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ class SourceGoogleAds(AbstractSource):
@staticmethod
def get_credentials(config: Mapping[str, Any]) -> Mapping[str, Any]:
credentials = config["credentials"]
# use_proto_plus is set to True, because setting to False returned wrong value types, which breakes the backward compatibility.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sherifnada Added comment here.

# For more info read the related PR's description: https://github.com/airbytehq/airbyte/pull/9996
credentials.update(use_proto_plus=True)

# https://developers.google.com/google-ads/api/docs/concepts/call-structure#cid
if "login_customer_id" in config and config["login_customer_id"].strip():
Expand Down