🐛 CDK: fixing type errors #9926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sergei-solonitcyn
approved these changes
Feb 1, 2022
keu
reviewed
Feb 8, 2022
Comment on lines
210
to
215
| # mypy raises error 'Incompatible types in assignment (expression has type "str", variable has type "List[str]")' | ||
| # type of path is first initialized as List[str] on the line 201 | ||
| # however str is assigned on the line below, it causes error | ||
| # to avoid code changing it was ignored for resolving issue CDK: typing errors #9500 | ||
| path = "/".join([p for p in path[:-1] if p not in ["properties", "oneOf"]]) # type: ignore | ||
| pathes.add(path) |
There was a problem hiding this comment.
Suggested change
| # mypy raises error 'Incompatible types in assignment (expression has type "str", variable has type "List[str]")' | |
| # type of path is first initialized as List[str] on the line 201 | |
| # however str is assigned on the line below, it causes error | |
| # to avoid code changing it was ignored for resolving issue CDK: typing errors #9500 | |
| path = "/".join([p for p in path[:-1] if p not in ["properties", "oneOf"]]) # type: ignore | |
| pathes.add(path) | |
| path_str = "/".join([p for p in path[:-1] if p not in ["properties", "oneOf"]]) # type: ignore | |
| pathes.add(path_str) |
keu
reviewed
Feb 8, 2022
Comment on lines
218
to
222
| # mypy raises error 'Incompatible return value type (got "Set[List[str]]", expected "Set[str]")' | ||
| # path is added into pathes, type of path is initialized as List[str] on the line 201 | ||
| # however Set[str] is expected returned type | ||
| # to avoid code changing it was ignored for resolving issue CDK: typing errors #9500 | ||
| return pathes # type: ignore |
There was a problem hiding this comment.
Suggested change
| # mypy raises error 'Incompatible return value type (got "Set[List[str]]", expected "Set[str]")' | |
| # path is added into pathes, type of path is initialized as List[str] on the line 201 | |
| # however Set[str] is expected returned type | |
| # to avoid code changing it was ignored for resolving issue CDK: typing errors #9500 | |
| return pathes # type: ignore | |
| return pathes |
sherifnada
approved these changes
Feb 10, 2022
keu
reviewed
Feb 12, 2022
| # to avoid code changing it was ignored for resolving issue CDK: typing errors #9500 | ||
| path = "/".join([p for p in path[:-1] if p not in ["properties", "oneOf"]]) # type: ignore | ||
| pathes.add(path) | ||
| path_str = "/".join([p for p in path[:-1] if p not in ["properties", "oneOf"]]) # type: ignore |
There was a problem hiding this comment.
Suggested change
| path_str = "/".join([p for p in path[:-1] if p not in ["properties", "oneOf"]]) # type: ignore | |
| path_str = "/".join([p for p in path[:-1] if p not in ["properties", "oneOf"]]) |
keu
suggested changes
Feb 12, 2022
|
/publish-cdk dry-run=false
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Running mypy airbyte_cdk returns 46 typing errors. Fixing the issues.
Closes #9500
How
Fixing part of the issues. Fixing part of the issues, e.g, module "json" is not valid as a type.