Heartbeat for long running activity #9852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
jrhizor
approved these changes
Jan 27, 2022
| @@ -26,4 +26,11 @@ | |||
| .setRetryOptions(TemporalUtils.NO_RETRY) | |||
| .build(); | |||
|
|
|||
| public static final ActivityOptions LONG_RUN_OPTIONS = ActivityOptions.newBuilder() | |||
| .setScheduleToCloseTimeout(Duration.ofDays(MAX_SYNC_TIMEOUT_DAYS)) | |||
There was a problem hiding this comment.
I think we want this to be start to close, not schedule to close.
There was a problem hiding this comment.
It s propagated to all the other arguments. Will make it explicit.
I was think about doing that in another PR in order to limit the change that will be released. |
This was referenced Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add an heartbeat for tghe long running activities