Skip to content

validate json schema on write #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 24, 2020
Merged

validate json schema on write #98

merged 2 commits into from
Aug 24, 2020

Conversation

cgardens
Copy link
Contributor

closes #51

What

  • validate that a config meets its json schema when we write it. right now we only validate on read which doesn't make a whole lot of sense.

@cgardens cgardens requested review from jrhizor and sherifnada August 24, 2020 18:54
@cgardens cgardens merged commit e3fadb3 into master Aug 24, 2020
@cgardens cgardens deleted the cgardens/validate_configs_on_write branch August 24, 2020 19:11
@hugoJuhel hugoJuhel mentioned this pull request Mar 16, 2022
Merged
21 tasks
@ptiurin ptiurin mentioned this pull request Sep 15, 2022
Closed
14 tasks
@rskrishnar rskrishnar mentioned this pull request Mar 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhizor jrhizor jrhizor approved these changes

@sherifnada sherifnada Awaiting requested review from sherifnada

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validation of configurations should happen before persistence
2 participants
@cgardens @jrhizor