Skip to content

add getConfigWithMetadata method to ConfigPersistence #9795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 25, 2022

Conversation

lmossman
Copy link
Contributor

What

Adds a method to get a single config with metadata, as there is currently only a method to list all configs in a table with metadata.

How

Looks very similar to listConfigsWithMetadata, except that it only fetches a single record.

Recommended reading order

  1. ConfigPersistence.java
  2. DatabaseConfigPersistence.java
  3. DeprecatedDatabaseConfigPersistence.java
  4. Tests

@lmossman lmossman temporarily deployed to more-secrets January 25, 2022 20:16 Inactive
Copy link
Contributor

@subodh1810 subodh1810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@lmossman lmossman merged commit 8f46b37 into master Jan 25, 2022
@lmossman lmossman deleted the lmossman/get-single-config-with-metadata branch January 25, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants