Skip to content

[MVP] Integrate sentry to all java-based connectors #9745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Jan 30, 2022
Merged

[MVP] Integrate sentry to all java-based connectors #9745

merged 29 commits into from
Jan 30, 2022

Conversation

alexandertsukanov
Copy link
Contributor

@alexandertsukanov alexandertsukanov commented Jan 24, 2022 •
edited by tuliren
Loading

What

  • Integrate Sentry to all Java-based connectors.

How

  • Add Sentry SDK.
  • Add APPLICATION_VERSION in Dockerfile.
  • Activate Sentry tracing when ENABLE_SENTRY is true.

Recommended reading order

  • Dockerfile
  • IntegrationRunner.java
  • AirbyteSentry.java

🚨 User Impact 🚨

No user impact.

@github-actions github-actions bot added the area/connectors Connector related issues label Jan 24, 2022
@alexandertsukanov alexandertsukanov linked an issue Jan 24, 2022 that may be closed by this pull request
Experiment with Sentry performance monitoring for BigQuery destination #9328
Closed
alexandr-shegeda
alexandr-shegeda approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@alexandr-shegeda alexandr-shegeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandertsukanov alexandertsukanov temporarily deployed to more-secrets January 25, 2022 12:42 Inactive
@alexandertsukanov alexandertsukanov temporarily deployed to more-secrets January 26, 2022 12:55 Inactive
@alexandertsukanov alexandertsukanov temporarily deployed to more-secrets January 26, 2022 12:59 Inactive
@alexandertsukanov alexandertsukanov temporarily deployed to more-secrets January 26, 2022 13:06 Inactive
@alexandertsukanov alexandertsukanov temporarily deployed to more-secrets January 26, 2022 15:12 Inactive
@alexandertsukanov alexandertsukanov changed the title [DRAFT_PR] Destination Snowflake, Destination BigQuery, Destination BigQuery-denormalized: add Sentry support Destination Snowflake, Destination BigQuery, Destination BigQuery-denormalized: add Sentry support Jan 27, 2022
@alexandertsukanov alexandertsukanov temporarily deployed to more-secrets January 27, 2022 15:31 Inactive
@alexandertsukanov alexandertsukanov temporarily deployed to more-secrets January 27, 2022 17:01 Inactive
@tuliren
Copy link
Contributor

tuliren commented Jan 27, 2022

It looks like many changes are needed to actually make the integration work on cloud. The best strategy is probably to add the DSN directly in the dockerfile of snowflake and bigquery, and limit the changes to those two connectors first.

I will experiment this locally, and make some necessary changes to this PR, so that we can merge this one as soon as possible.

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jan 29, 2022
@tuliren tuliren temporarily deployed to more-secrets January 29, 2022 11:01 Inactive
@tuliren tuliren temporarily deployed to more-secrets January 29, 2022 11:10 Inactive
@tuliren
Copy link
Contributor

tuliren commented Jan 29, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-e2e-test

🕑 connectors/destination-e2e-test https://github.com/airbytehq/airbyte/actions/runs/1766841058
❌ connectors/destination-e2e-test https://github.com/airbytehq/airbyte/actions/runs/1766841058

@tuliren
Copy link
Contributor

tuliren commented Jan 29, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-dev-null

🕑 connectors/destination-dev-null https://github.com/airbytehq/airbyte/actions/runs/1766841397
❌ connectors/destination-dev-null https://github.com/airbytehq/airbyte/actions/runs/1766841397

@tuliren
Copy link
Contributor

tuliren commented Jan 29, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-e2e-test

🕑 connectors/source-e2e-test https://github.com/airbytehq/airbyte/actions/runs/1766841605
❌ connectors/source-e2e-test https://github.com/airbytehq/airbyte/actions/runs/1766841605

@tuliren
Copy link
Contributor

tuliren commented Jan 29, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-e2e-test-cloud

🕑 connectors/source-e2e-test-cloud https://github.com/airbytehq/airbyte/actions/runs/1766841823
❌ connectors/source-e2e-test-cloud https://github.com/airbytehq/airbyte/actions/runs/1766841823

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 29, 2022 21:23 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 29, 2022 21:23 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 29, 2022 21:24 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 29, 2022 21:24 Inactive
@tuliren
Copy link
Contributor

tuliren commented Jan 30, 2022

Publishing is blocked. I will revert the version bump, and publish the connectors in follow-up PRs.

@tuliren tuliren temporarily deployed to more-secrets January 30, 2022 00:31 Inactive
@tuliren tuliren temporarily deployed to more-secrets January 30, 2022 00:34 Inactive
@tuliren
Copy link
Contributor

tuliren commented Jan 30, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-e2e-test

🕑 connectors/source-e2e-test https://github.com/airbytehq/airbyte/actions/runs/1767279676
✅ connectors/source-e2e-test https://github.com/airbytehq/airbyte/actions/runs/1767279676
No Python unittests run

@tuliren
Copy link
Contributor

tuliren commented Jan 30, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/destination-e2e-test

🕑 connectors/destination-e2e-test https://github.com/airbytehq/airbyte/actions/runs/1767279666
✅ connectors/destination-e2e-test https://github.com/airbytehq/airbyte/actions/runs/1767279666
No Python unittests run

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 30, 2022 00:53 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 30, 2022 00:53 Inactive
@tuliren tuliren merged commit 479f0d7 into master Jan 30, 2022
@tuliren tuliren deleted the otsukanov/airbyte-9328 branch January 30, 2022 00:58
tuliren added a commit that referenced this pull request Jan 30, 2022
@tuliren
Revert "[MVP] Integrate sentry to all java-based connectors (#9745)"
4ae1381 
This reverts commit 479f0d7.
@tuliren tuliren mentioned this pull request Jan 30, 2022
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 31, 2022
Merged
@tuliren tuliren mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuliren tuliren tuliren left review comments

@alexandr-shegeda alexandr-shegeda alexandr-shegeda approved these changes

@andriikorotkov andriikorotkov andriikorotkov approved these changes

@sherifnada sherifnada Awaiting requested review from sherifnada

@subodh1810 subodh1810 Awaiting requested review from subodh1810

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Experiment with Sentry performance monitoring for BigQuery destination
6 participants
@alexandertsukanov @tuliren @sherifnada @alexandr-shegeda @andriikorotkov @octavia-squidington-iii