-
Notifications
You must be signed in to change notification settings - Fork 4.5k
🐙 octavia-cli: implement init command #9665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37ae4e3
to
88bfbb2
Compare
Base automatically changed from
augustin/octavia-cli/list-sources-destinations
to
master
January 25, 2022 09:12
a4ee3d6
to
25bff28
Compare
bb4295a
to
07e63f9
Compare
07e63f9
to
3523d46
Compare
3523d46
to
7886001
Compare
lmossman
approved these changes
Feb 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left a couple small suggestions and question but nothing is blocking, so feel free to merge when ready!
Thank you @lmossman for the review, I improved the error messages as you suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In order to create and manage configurations, we want them to be stored in a specific project directory architecture.
This PR implement
octavia init
command that will create the directory architecture in the current working directory:How
Declare a new
init
command which creates required directories in current working directory.Nondestructive approach: the
init
command does not recreate subdirectories that already exist.Add to the CLI context the
PROJECT_IS_INITIALIZED
boolean to enable other command to not run if project is not initialized.Bonus:
Recommended reading order
octavia-cli/octavia_cli/init/commands.py
+octavia-cli/unit_tests/test_init/test_commands.py
octavia-cli/octavia_cli/check_context.py
+octavia-cli/unit_tests/test_check_context.py
octavia-cli/octavia_cli/entrypoint.py
+octavia-cli/unit_tests/test_entrypoin.py
🚨 User Impact 🚨
New

octavia init
command:Coming next
Our execution plan