Add Dataline types to interface for check connection and discovery workers #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgardens
commented
Aug 19, 2020
| @@ -0,0 +1,114 @@ | |||
| { | |||
There was a problem hiding this comment.
yolo. i tried to create a jscon schema configuration for catalog.json to make all the type parsing easier. 🤞 that it's good enough. with the lack of consistency in singer, i'm a big worried, but for now it's helpful.
There was a problem hiding this comment.
based off the example on the singer webpage.
cgardens
commented
Aug 19, 2020
|
|
||
| import io.dataline.config.StandardConnectionStatus; | ||
|
|
||
| public interface CheckConnectionWorker extends Worker<StandardConnectionStatus> { |
There was a problem hiding this comment.
trying to make it very clear what the contract is for each job type. CheckConnection outputs StandardConnectionStatus. Discover outputs StandardDiscoveryOutput. Ideally we'd be able to get the input types (e.g. connection configuration). will look at that subsequently.
cgardens
commented
Aug 19, 2020
| } | ||
| } | ||
|
|
||
| private static StandardDiscoveryOutput toDiscoveryOutput(SingerCatalog catalog) { |
There was a problem hiding this comment.
singer catalog to our schema data model.
sherifnada
approved these changes
Aug 19, 2020
21 tasks
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What