-
Notifications
You must be signed in to change notification settings - Fork 4.5k
🎉 Source Mysql - added basic MySql performance tests #7820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Source Mysql - added basic MySql performance tests #7820
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
One general suggestion is to use jOOQ code to construct the queries. In that way, many of the string templates can be omitted. But this is not a high priority requirement. Only do it if you think it helps.
...src/main/java/io/airbyte/integrations/standardtest/source/AbstractSourcePerformanceTest.java
Show resolved
Hide resolved
...c/test-performance/java/io/airbyte/integrations/source/mysql/MySqlSourcePerformanceTest.java
Outdated
Show resolved
Hide resolved
* Added new slash command as a prerequisite for #7820
/test connector=connectors/source-mysql
|
/test-performance connector=connectors/source-mysql
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work!
) * Added new slash command as a prerequisite for airbytehq#7820
* [ticket 7489, PR 7820] Source Mysql - added skeleton for MySql performance tests
What
We want to perform more performance tests for connectors.
How
Added skeleton and base tests for the Source MySQL connector.
Since now we would be able to run performance tests locally or by leaving a PR's comment.
Locally: "./gradlew clean :airbyte-integrations:connectors:source-mysql:performanceTest"
In comment: "/test-performance connector=connectors/source-mysql"
As preconditions more scripts were added #7920
Recommended reading order
x.java
y.python
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes