Add Usage per connection block #7102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhizor
approved these changes
Jan 24, 2022
jamakase
commented
Feb 1, 2022
| @@ -14,4 +14,10 @@ const useDestinationDefinitionList = (): { | |||
| }); | |||
| }; | |||
|
|
|||
| export { useDestinationDefinitionList }; | |||
| const useDestinationDefinition = (id: string): DestinationDefinition => { | |||
There was a problem hiding this comment.
The main idea of adding name and ids into CreditConsumptionByConnector is to not make a bunch of additional requests to backend and be able to get info from request or cache.
Are we sending here request for every such entity? Or is it picked from cache? I believe we retrieve these entities only to display icons.
We should make sure that we either:
- pick info from cache for icons if possible
- expand CreditConsumptionByConnector entity with icon, so we won't make bunch of unnecessary requests.
jamakase
commented
Feb 4, 2022
| destinationIcon: currentDestinationDefinition?.icon, | ||
| creditsConsumedPercent: | ||
| item.creditsConsumed !== 0 | ||
| ? (item.creditsConsumed / sumCreditsConsumed) * 100 |
There was a problem hiding this comment.
What if sumCreditsConsumed is 0? I think we could change it to sumCreditsConsumed ? item.creditsConsumed / sumCreditsConsumed * 100 : 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds table with per-connection billing.
Closes #6956