🎉 Source Bing Ads: support oauth #6831
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
area/connectors
1 task
|
/test connector=connectors/source-bing-ads
|
bazarnov
approved these changes
Oct 6, 2021
antixar
reviewed
Oct 7, 2021
Comment on lines
84
to
89
| "access_token": { | ||
| "type": "string", | ||
| "description": "Access token generated using developer_token, client_id, and client_secret.", | ||
| "airbyte_secret": true | ||
| }, | ||
| "refresh_token": { |
There was a problem hiding this comment.
where is this parameter used? I don't see changes of business logic
antixar
approved these changes
Oct 8, 2021
davinchia
approved these changes
Oct 12, 2021
sherifnada
reviewed
Oct 14, 2021
| "oauth2Specification": { | ||
| "rootObject": [], | ||
| "oauthFlowInitParameters": [["client_id"], ["client_secret"], ["developer_token"], ["user_id"]], | ||
| "oauthFlowOutputParameters": [["client_id"], ["client_secret"], ["developer_token"], ["user_id"], ["refresh_token"]] |
There was a problem hiding this comment.
id/secret/token are init parameters, not output params, I believe?
There was a problem hiding this comment.
Output params too. Need these params to get a new access token after the expiry.
sherifnada
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Source Bing Ads: support oauth - #6294
How
spec.jsonRecommended reading order
x.javay.pythonPre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.docs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described hereThis change is