Skip to content

🎉 New Source: Appsflyer #6497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Oct 19, 2021
Merged

Conversation

asyarif93
Copy link
Contributor

@asyarif93 asyarif93 commented Sep 28, 2021

What

Adding new connector Appsflyer using CDK
Resolves #5718

How

Describe the solution

Recommended reading order

  1. spec.json
  2. source.py

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@CLAassistant
Copy link

CLAassistant commented Sep 28, 2021

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the area/connectors Connector related issues label Sep 28, 2021
@asyarif93
Copy link
Contributor Author

asyarif93 commented Sep 28, 2021

Unit test result:

python -m pytest -s unit_tests                                                                                                                                ─╯
Test session starts (platform: linux, Python 3.8.10, pytest 6.2.5, pytest-sugar 0.9.4)
cachedir: .pytest_cache
rootdir: /home/lpt393/projects/airbyte, configfile: pytest.ini
plugins: timeout-1.4.2, mock-3.6.1, sugar-0.9.4
collecting ... 
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_cursor_field ✓                                          2% ▎         
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_cursor_field_in_app_events ✓                            4% ▌         
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_cursor_field_uninstall_events ✓                         6% ▋         
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_cursor_field_retargeting_in_app_events ✓                8% ▊         
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_cursor_field_installs ✓                                10% █         
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_cursor_field_retargeting_conversions ✓                 12% █▎        
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_cursor_field_partners_report ✓                         14% █▌        
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_cursor_field_daily_report ✓                            16% █▋        
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_cursor_field_geo_report ✓                              18% █▉        
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_request_params_in_app_events ✓                         20% ██▏       
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_request_params_installs ✓                              22% ██▎       
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_request_params_retargeting_in_app_events ✓             24% ██▌       
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_request_params_retargeting_conversions ✓               27% ██▋       
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_request_params_uninstall_events ✓                      29% ██▉       
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_request_params_partners_report ✓                       31% ███▏      
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_request_params_daily_report ✓                          33% ███▍      
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_request_params_geo_report ✓                            35% ███▌      
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_request_params_retargeting_partners_report ✓           37% ███▋      
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_request_params_retargeting_daily_report ✓              39% ███▉      
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_request_params_retargeting_geo_report ✓                41% ████▏     
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_get_updated_state_all_exists ✓                         43% ████▍     
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_get_updated_state_empty_current_stream_and_empty_latest_record ✓45% ████▌     
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_get_updated_state_empty_current_stream_and_exists_latest_record ✓47% ████▊     
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_get_updated_state_exists_current_stream_and_empty_latest_record ✓49% ████▉     
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_get_updated_state_all_unparseable ✓                    51% █████▏    
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_stream_slices ✓                                        53% █████▍    
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_supports_incremental ✓                                 55% █████▌    
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_source_defined_cursor ✓                                57% █████▊    
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_stream_checkpoint_interval ✓                           59% █████▉    
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_source.py::test_check_connection_expected_ok ✓                                      61% ██████▎   
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_source.py::test_check_connection_expected_app_id_invalid ✓                          63% ██████▍   
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_source.py::test_check_connection_expected_api_token_invalid ✓                       65% ██████▌   {"type": "LOG", "log": {"level": "INFO", "message": "Using start_date: 2021-09-13T01:00:00+00:00, end_date: 2021-09-28T07:57:31.913919+00:00"}}

airbyte-integrations/connectors/source-appsflyer/unit_tests/test_source.py::test_streams ✓ 67% ██████▊
airbyte-integrations/connectors/source-appsflyer/unit_tests/test_streams.py::test_request_params ✓ 69% ██████▉
airbyte-integrations/connectors/source-appsflyer/unit_tests/test_streams.py::test_parse_response_return_ok ✓ 71% ███████▎
airbyte-integrations/connectors/source-appsflyer/unit_tests/test_streams.py::test_parse_response_return_empty_row ✓ 73% ███████▍
airbyte-integrations/connectors/source-appsflyer/unit_tests/test_streams.py::test_http_method ✓ 76% ███████▋
airbyte-integrations/connectors/source-appsflyer/unit_tests/test_streams.py::test_should_retry[HTTPStatus.OK-False] ✓ 78% ███████▊
airbyte-integrations/connectors/source-appsflyer/unit_tests/test_streams.py::test_should_retry[HTTPStatus.BAD_REQUEST-False] ✓ 80% ███████▉
airbyte-integrations/connectors/source-appsflyer/unit_tests/test_streams.py::test_should_retry[HTTPStatus.TOO_MANY_REQUESTS-True] ✓ 82% ████████▎
airbyte-integrations/connectors/source-appsflyer/unit_tests/test_streams.py::test_should_retry[HTTPStatus.INTERNAL_SERVER_ERROR-True] ✓ 84% ████████▍
airbyte-integrations/connectors/source-appsflyer/unit_tests/test_streams.py::test_should_retry_raw_data ✓ 86% ████████▋
airbyte-integrations/connectors/source-appsflyer/unit_tests/test_streams.py::test_should_retry_aggregate_data ✓ 88% ████████▊
airbyte-integrations/connectors/source-appsflyer/unit_tests/test_streams.py::test_backoff_time_default[HTTPStatus.OK-None] ✓ 90% █████████
airbyte-integrations/connectors/source-appsflyer/unit_tests/test_streams.py::test_backoff_time_default[HTTPStatus.BAD_REQUEST-None] ✓ 92% █████████▎
airbyte-integrations/connectors/source-appsflyer/unit_tests/test_streams.py::test_backoff_time_default[HTTPStatus.TOO_MANY_REQUESTS-None] ✓ 94% █████████▍
airbyte-integrations/connectors/source-appsflyer/unit_tests/test_streams.py::test_backoff_time_default[HTTPStatus.INTERNAL_SERVER_ERROR-None] ✓ 96% █████████▋{"type": "LOG", "log": {"level": "INFO", "message": "Rate limit exceded. Retry in 60 seconds."}}

airbyte-integrations/connectors/source-appsflyer/unit_tests/test_streams.py::test_backoff_time_aggregate_data ✓ 98% █████████▊{"type": "LOG", "log": {"level": "INFO", "message": "Rate limit exceded. Retry in 57748 seconds."}}

airbyte-integrations/connectors/source-appsflyer/unit_tests/test_streams.py::test_backoff_time_raw_data ✓ 100% ██████████

Results (0.32s):
49 passed

@asyarif93 asyarif93 marked this pull request as ready for review September 28, 2021 07:58
@asyarif93
Copy link
Contributor Author

Unit test result:

python -m pytest -s unit_tests                                                               ─╯
Test session starts (platform: linux, Python 3.8.10, pytest 6.2.5, pytest-sugar 0.9.4)
cachedir: .pytest_cache
rootdir: /home/lpt393/projects/airbyte, configfile: pytest.ini
plugins: timeout-1.4.2, mock-3.6.1, sugar-0.9.4
collecting ... 
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_cursor_field ✓2% ▎         
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_cursor_field_in_app_events ✓4% ▌         
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_cursor_field_uninstall_events ✓6% ▋         
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_cursor_field_retargeting_in_app_events ✓8% ▉         
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_cursor_field_installs ✓10% █▏        
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_cursor_field_retargeting_conversions ✓12% █▍        
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_cursor_field_partners_report ✓15% █▌        
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_cursor_field_daily_report ✓17% █▋        
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_cursor_field_geo_report ✓19% █▉        
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_request_params_in_app_events ✓21% ██▏       
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_request_params_installs ✓23% ██▍       
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_request_params_retargeting_in_app_events ✓25% ██▌       
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_request_params_retargeting_conversions ✓27% ██▊       
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_request_params_uninstall_events ✓29% ██▉       
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_request_params_partners_report ✓31% ███▎      
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_request_params_daily_report ✓33% ███▍      
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_request_params_geo_report ✓35% ███▋      
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_request_params_retargeting_partners_report ✓38% ███▊      
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_request_params_retargeting_daily_report ✓40% ███▉      
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_request_params_retargeting_geo_report ✓42% ████▎     
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_get_updated_state_all_exists ✓44% ████▍     
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_get_updated_state_empty_current_stream_and_empty_latest_record ✓46% ████▋     
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_get_updated_state_empty_current_stream_and_exists_latest_record ✓48% ████▊     
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_get_updated_state_exists_current_stream_and_empty_latest_record ✓50% █████     
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_stream_slices ✓52% █████▎    
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_supports_incremental ✓54% █████▌    
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_source_defined_cursor ✓56% █████▋    
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_incremental_streams.py::test_stream_checkpoint_interval ✓58% █████▉    
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_source.py::test_check_connection_expected_ok ✓60% ██████▏   
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_source.py::test_check_connection_expected_app_id_invalid ✓62% ██████▍   
 airbyte-integrations/connectors/source-appsflyer/unit_tests/test_source.py::test_check_connection_expected_api_token_invalid ✓65% ██████▌   {"type": "LOG", "log": {"level": "INFO", "message": "Using start_date: 2021-09-13T01:00:00+00:00, end_date: 2021-09-29T14:31:47.450424+00:00"}}

airbyte-integrations/connectors/source-appsflyer/unit_tests/test_source.py::test_streams ✓67% ██████▋
airbyte-integrations/connectors/source-appsflyer/unit_tests/test_streams.py::test_request_params ✓69% ██████▉
airbyte-integrations/connectors/source-appsflyer/unit_tests/test_streams.py::test_parse_response_return_ok ✓71% ███████▏
airbyte-integrations/connectors/source-appsflyer/unit_tests/test_streams.py::test_parse_response_return_empty_row ✓73% ███████▍
airbyte-integrations/connectors/source-appsflyer/unit_tests/test_streams.py::test_http_method ✓75% ███████▌
airbyte-integrations/connectors/source-appsflyer/unit_tests/test_streams.py::test_should_retry[HTTPStatus.OK-False] ✓77% ███████▊
airbyte-integrations/connectors/source-appsflyer/unit_tests/test_streams.py::test_should_retry[HTTPStatus.BAD_REQUEST-False] ✓79% ███████▉
airbyte-integrations/connectors/source-appsflyer/unit_tests/test_streams.py::test_should_retry[HTTPStatus.TOO_MANY_REQUESTS-True] ✓81% ████████▎
airbyte-integrations/connectors/source-appsflyer/unit_tests/test_streams.py::test_should_retry[HTTPStatus.INTERNAL_SERVER_ERROR-True] ✓83% ████████▍
airbyte-integrations/connectors/source-appsflyer/unit_tests/test_streams.py::test_should_retry_raw_data ✓85% ████████▋
airbyte-integrations/connectors/source-appsflyer/unit_tests/test_streams.py::test_should_retry_aggregate_data ✓88% ████████▊
airbyte-integrations/connectors/source-appsflyer/unit_tests/test_streams.py::test_backoff_time_default[HTTPStatus.OK-None] ✓90% ████████▉
airbyte-integrations/connectors/source-appsflyer/unit_tests/test_streams.py::test_backoff_time_default[HTTPStatus.BAD_REQUEST-None] ✓92% █████████▎
airbyte-integrations/connectors/source-appsflyer/unit_tests/test_streams.py::test_backoff_time_default[HTTPStatus.TOO_MANY_REQUESTS-None] ✓94% █████████▍
airbyte-integrations/connectors/source-appsflyer/unit_tests/test_streams.py::test_backoff_time_default[HTTPStatus.INTERNAL_SERVER_ERROR-None] ✓96% █████████▋{"type": "LOG", "log": {"level": "INFO", "message": "Rate limit exceded. Retry in 60 seconds."}}

airbyte-integrations/connectors/source-appsflyer/unit_tests/test_streams.py::test_backoff_time_aggregate_data ✓98% █████████▊{"type": "LOG", "log": {"level": "INFO", "message": "Rate limit exceded. Retry in 34092 seconds."}}

airbyte-integrations/connectors/source-appsflyer/unit_tests/test_streams.py::test_backoff_time_raw_data ✓100% ██████████

Results (0.31s):
48 passed

@asyarif93
Copy link
Contributor Author

Acceptance test result:

python -m pytest -p integration_tests.acceptance                                                               ─╯
Test session starts (platform: linux, Python 3.8.10, pytest 6.2.5, pytest-sugar 0.9.4)
cachedir: .pytest_cache
rootdir: /home/lpt393/projects/airbyte, configfile: pytest.ini
plugins: timeout-1.4.2, mock-3.6.1, sugar-0.9.4
collecting ... 
 airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py::TestSpec.test_match_expected[inputs0] ✓     8% ▊         
 airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py::TestSpec.test_required[inputs0] ✓          15% █▋        
 airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py::TestSpec.test_optional[inputs0] ✓          23% ██▍       
 airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py::TestSpec.test_has_secret[inputs0] ✓        31% ███▏      
 airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py::TestSpec.test_secret_never_in_the_output[inputs0] ✓38% ███▉      
 airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py::TestConnection.test_check[inputs0] ✓       46% ████▋     
 airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py::TestConnection.test_check[inputs1] ✓       54% █████▍    
 airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py::TestDiscovery.test_discover[inputs0] ✓     62% ██████▎   
 airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py::TestD0] ✓69% ██████▉   
 airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py::TestBasicRead.test_read[inputs0] ✓77% ███████▊  
 airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_full_refresh.py::TestFullRefresh.test_sequential_reads[inputs0] ✓85% ████████▌ 
 airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_incremental.py::TestIncremental.test_two_sequential_reads[inputs0] ✓92% █████████▎
 airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_incremental.py::TestIncremental.test_state_with_abnormally_large_values[inputs0] ✓100% ██████████

Results (506.83s):
13 passed

@harshithmullapudi
Copy link
Contributor

Hey @asyarif93 thanks for your contribution 🔥 . We are currently focusing cloud launch we will be able to get back and review early next week.

Copy link
Contributor

@avida avida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main point is to use CDK transform class instead of custom transformation code. It super easy to config just with one line. Here is details : https://docs.airbyte.io/connector-development/cdk-python/schemas#default-type-transformation

@avida
Copy link
Contributor

avida commented Oct 8, 2021

@asyarif93, thanks for commits. Please write you consideration on using CDK transform class. If it fits to your needs to do transformation? If no, how we can modify Transformer class to use it in you connector?
Would like to unify all data transformations in one place and keep connector code simple.

If it would take a lot of time and you want this connector asap we can merge it but create an issue to address this in some near future.

@asyarif93
Copy link
Contributor Author

asyarif93 commented Oct 8, 2021

I still wondering how to transform some data. for date-time and decimal type seems provided transform class can get the job done. for some other cases, e.g. i had to replace na with None, i might need implement CustomSchemaNormalization. is there any connector that use those class? i only see facebook marketing as primary example.

Also, seems I have realize that i'm using USD currencies while write fieldname with IDR suffix which is a bug. I have yet to decide, should I force everything in USD or allow user to chose their preference, If the latter, I might need override Stream.get_json_schema and check if currency code is ISO 4217 valid --and make those unit test first

(edit) seems my airbyte-cdk was before airbyte_cdk.sources.utils.transform available (my version was 0.1.17). is there anything i need to change after update airbyte-cdk to 0.1.25?

@asyarif93 asyarif93 force-pushed the asyarif93/appsflyer branch from 022e671 to 0aeae20 Compare October 9, 2021 09:23
@avida
Copy link
Contributor

avida commented Oct 11, 2021

@asyarif93,

I still wondering how to transform some data. for date-time and decimal type seems provided transform class can get the job done. for some other cases, e.g. i had to replace na with None, i might need implement CustomSchemaNormalization. is there any connector that use those class? i only see facebook marketing as primary example.

This feature is new, AFAIK o connector using it so far. You can find examples of custom transformation in docs: https://docs.airbyte.io/connector-development/cdk-python/schemas#custom-schema-type-transformation

class MyStream(Stream):
    ...
    transformer = Transformer(TransformConfig.DefaultSchemaNormalization | TransformConfig.CustomSchemaNormalization)
    ...

    @transformer.registerCustomTransform
    def transform_function(orginal_value: Any, field_schema: Dict[str, Any]) -> Any:
        if orginal_value == 'na':
               return None
        return transformed_value

Note that transform_function should not take self argument.

(edit) seems my airbyte-cdk was before airbyte_cdk.sources.utils.transform available (my version was 0.1.17). is there anything i need to change after update airbyte-cdk to 0.1.25?

You have to set CDK version in dependencies and add

transformer = Transformer(TransformConfig.DefaultSchemaNormalization)

to your class member variables (details)

Copy link
Contributor

@avida avida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks for the commitment and special thanks for great unit tests.

@asyarif93
Copy link
Contributor Author

asyarif93 commented Oct 12, 2021

I still need to add Documentation, and maybe a feature to allow user use their prefered currency first.

@harshithmullapudi
Copy link
Contributor

@avida we can merge this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Source Appsflyer with CDK
7 participants