pass in persistence paths as env variables #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgardens
commented
Aug 14, 2020
| import javax.ws.rs.core.HttpHeaders; | ||
| import org.glassfish.hk2.api.Factory; | ||
|
|
||
| public class ConfigurationApiFactory implements Factory<ConfigurationApi> { |
There was a problem hiding this comment.
following suggestion from here https://stackoverflow.com/questions/16216759/dependency-injection-with-jersey-2-0/29275727#29275727. the use of the static field to pass in the param still feels jenky. maybe i'm missing something smarter?
cgardens
commented
Aug 14, 2020
| @@ -64,6 +80,6 @@ public void start() throws Exception { | |||
| public static void main(String[] args) throws Exception { | |||
| LOGGER.info("Starting server..."); | |||
|
|
|||
| new ServerApp().start(); | |||
| new ServerApp("/Users/charles/code/dataline/data/config").start(); | |||
There was a problem hiding this comment.
todo: actually move this into a env variable. i will do this before i merge.
michel-tricot
approved these changes
Aug 17, 2020
cgardens
force-pushed
the
cgardens/persistence_root
branch
from
acefa4e to
42bc19f
Compare
cgardens
force-pushed
the
cgardens/persistence_root
branch
from
42bc19f to
268298b
Compare
21 tasks
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What