Skip to content

Disable automatic migration acceptance test #5988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 15, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,11 @@

public class MigrationCurrentSchemaTest {

/**
* The file-based migration is deprecated. We need to ensure that v0.29.0 is the last one. All new
* migrations should be written in Flyway.
*/
@Test
public void testLastMigration() {
final Migration lastMigration = Migrations.MIGRATIONS.get(Migrations.MIGRATIONS.size() - 1);
assertEquals(Migrations.MIGRATION_V_0_29_0.getVersion(), lastMigration.getVersion());
assertEquals(Migrations.MIGRATION_V_0_29_0.getVersion(), lastMigration.getVersion(),
"The file-based migration is deprecated. Please do not write a new migration this way. Use Flyway instead.");
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
import java.util.Properties;
import java.util.Set;
import java.util.function.Consumer;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
Expand All @@ -77,7 +78,11 @@ public class MigrationAcceptanceTest {
// assume env file is one directory level up from airbyte-tests.
private final static File ENV_FILE = Path.of(System.getProperty("user.dir")).getParent().resolve(".env").toFile();

/**
* This test is deprecated because it no longer works after the introduce of the Flyway migration.
*/
@Test
@Disabled
public void testAutomaticMigration() throws Exception {
// default to version in env file but can override it.
final String targetVersion;
Expand Down