fix(source-pipedrive): update connector to use v2 API endpoints #59676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update has several changes: - Updated to Pipedrive API v2 endpoints where applicable - Substituted usage of `/v1/recents` for streams to their actual object endpoint in the API. Reason: `/v1/recents` exclude items that don't have update_time, which might occur in old records of Pipedrive. - Renamed streams that were using CamelCase to snake_case. - Added organization_relationships stream.
|
@hanslemm is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
hanslemm
changed the title
marcosmarxm
requested changes
May 6, 2025
There was a problem hiding this comment.
@hanslemm thanks for your contribution, you need to also bump the metadata and doc connector version so I'll trigger tests.
| title: API Token | ||
| airbyte_secret: true | ||
| order: 0 | ||
| replication_start_date: | ||
| start_date: |
There was a problem hiding this comment.
Is there a good reason to rename this parameter. It will cause a breaking change to all existing connections.
There was a problem hiding this comment.
Humm good point.
I just changed to the "standard" Airbyte naming according to the latest Connector Builder.
github-project-automation
bot
moved this from Backlog
to Waiting Contributor
in 🧑🏭 Community Pull Requests
marcosmarxm
changed the title
|
/run-connector-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This update has several changes:
/v1/recentsfor streams to their actual object endpoint in the API. Reason:/v1/recentsexcludes items that haveupdate_time = NULL, which might occur in old records of Pipedrive. One setback is that some streams had to become non-incremental due to this change.Request to community
Some streams I created/updated couldn't have their schemas verified, as my Pipedrive project doesn't have records for them. So I would appreciate it if the community could check the missing schemas.
User Impact
users) due to change fromv1/recentsto the correspondent object endpoint (e.g.:v1/users). But not all cases. Some were possible to sort the output so that we could use the data-feed to make it incremental.mailendpoint renamed tomail_messagesto keep consistency with API naming.Can this PR be safely reverted and rolled back?