Remove boilerplate code for enum conversion #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhizor
reviewed
Aug 14, 2020
| @@ -415,4 +315,33 @@ private SourceSchema toApiSchema(Schema persistenceSchema) { | |||
| apiSchema.setTables(persistenceTables); | |||
| return apiSchema; | |||
| } | |||
|
|
|||
| private StandardSync.Status toPersistenceStatus(ConnectionStatus apiStatus) { | |||
There was a problem hiding this comment.
Can we have unit tests that assert the completeness of this conversion by iterating through all enum values? Then we can guarantee correctness for each version of generated code.
cgardens
approved these changes
Aug 14, 2020
|
cool. |
21 tasks
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
JsonSchema duplicates enum definition which forces creating conversion methods. Let's streamline the conversion.
How
Convert enums from one enum to the next using name.
Tradeoff: static check becomes dynamic but this is alleviated by the fact that it is generated code.
If we want to keep the same exception message, let me know, I can create a overload with an exeptions generator. Right now the returned exception is:
java.lang.IllegalArgumentException: No enum constant io.dataline.commons.enums.EnumsTest.E2.TEST2