-
Notifications
You must be signed in to change notification settings - Fork 4.6k
[BigQuery] BulkLoader config #58087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BigQuery] BulkLoader config #58087
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
5cb77d6
to
45c9596
Compare
a72b07f
to
ff01262
Compare
ff01262
to
67d12a5
Compare
45c9596
to
ef1d680
Compare
67d12a5
to
1b1c91d
Compare
e3bf4d5
to
164c645
Compare
1b1c91d
to
6ddee2a
Compare
# Conflicts: # airbyte-cdk/bulk/toolkits/load-s3/src/main/kotlin/io/airbyte/cdk/load/command/s3/S3BucketSpecification.kt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had some comments, lgtm once resolved
sealed class GcsAuthSpecification( | ||
@JsonSchemaTitle("Credential Type") | ||
@get:JsonProperty("credential_type") | ||
val credentialType: Type | ||
val credentialType: Type = Type.HMAC_KEY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious: why do we need the default value?
...ain/kotlin/io/airbyte/integrations/destination/bigquery/formatter/BigQueryRecordFormatter.kt
Show resolved
Hide resolved
.../kotlin/io/airbyte/integrations/destination/bigquery/write/bulk_loader/BigQueryBulkLoader.kt
Outdated
Show resolved
Hide resolved
...rbyte/integrations/destination/bigquery/write/bulk_loader/BigQueryBulkLoaderConfiguration.kt
Outdated
Show resolved
Hide resolved
...rbyte/integrations/destination/bigquery/write/bulk_loader/BigQueryBulkLoaderConfiguration.kt
Outdated
Show resolved
Hide resolved
...rbyte/integrations/destination/bigquery/write/bulk_loader/BigQueryBulkLoaderConfiguration.kt
Outdated
Show resolved
Hide resolved
60de115
into
destination_bigquery_bulk_cdk
What
Implement the main change for the BulkLoader to work: The
BulkLoaderConfiguration
Can this PR be safely reverted and rolled back?