Skip to content

[BigQuery] BulkLoader config #58087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Apr 22, 2025

Conversation

frifriSF59
Copy link
Contributor

@frifriSF59 frifriSF59 commented Apr 15, 2025

What

Implement the main change for the BulkLoader to work: The BulkLoaderConfiguration

Can this PR be safely reverted and rolled back?

  • YES πŸ’š
  • NO ❌

@frifriSF59 frifriSF59 self-assigned this Apr 15, 2025
Copy link

vercel bot commented Apr 15, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
airbyte-docs βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Apr 22, 2025 7:57pm

@edgao edgao force-pushed the frifri/bq_bl_config branch from 5cb77d6 to 45c9596 Compare April 16, 2025 21:52
@edgao edgao force-pushed the destination_bigquery_bulk_cdk branch 3 times, most recently from a72b07f to ff01262 Compare April 17, 2025 15:13
@frifriSF59 frifriSF59 force-pushed the destination_bigquery_bulk_cdk branch from ff01262 to 67d12a5 Compare April 18, 2025 19:01
@frifriSF59 frifriSF59 force-pushed the frifri/bq_bl_config branch from 45c9596 to ef1d680 Compare April 18, 2025 19:03
@frifriSF59 frifriSF59 force-pushed the destination_bigquery_bulk_cdk branch from 67d12a5 to 1b1c91d Compare April 18, 2025 21:34
@frifriSF59 frifriSF59 force-pushed the frifri/bq_bl_config branch from e3bf4d5 to 164c645 Compare April 18, 2025 21:36
@frifriSF59 frifriSF59 force-pushed the destination_bigquery_bulk_cdk branch from 1b1c91d to 6ddee2a Compare April 21, 2025 16:08
# Conflicts:
#	airbyte-cdk/bulk/toolkits/load-s3/src/main/kotlin/io/airbyte/cdk/load/command/s3/S3BucketSpecification.kt
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had some comments, lgtm once resolved

sealed class GcsAuthSpecification(
@JsonSchemaTitle("Credential Type")
@get:JsonProperty("credential_type")
val credentialType: Type
val credentialType: Type = Type.HMAC_KEY
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious: why do we need the default value?

@frifriSF59 frifriSF59 merged commit 60de115 into destination_bigquery_bulk_cdk Apr 22, 2025
23 of 27 checks passed
@frifriSF59 frifriSF59 deleted the frifri/bq_bl_config branch April 22, 2025 22:26
edgao pushed a commit that referenced this pull request Apr 25, 2025
edgao pushed a commit that referenced this pull request Apr 28, 2025
edgao pushed a commit that referenced this pull request May 1, 2025
edgao pushed a commit that referenced this pull request May 1, 2025
edgao pushed a commit that referenced this pull request May 2, 2025
edgao pushed a commit that referenced this pull request May 6, 2025
frifriSF59 added a commit that referenced this pull request May 6, 2025
edgao pushed a commit that referenced this pull request May 6, 2025
edgao pushed a commit that referenced this pull request May 6, 2025
edgao pushed a commit that referenced this pull request May 7, 2025
edgao pushed a commit that referenced this pull request May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants