Skip to content

Add a variant of the CDK speedrun that uses the PokeAPI #5780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2021

Conversation

avaidyanatha
Copy link
Contributor

@avaidyanatha avaidyanatha commented Sep 1, 2021

Main Changes

  • We are slowly deprecating the ExchangeRates API out of our docs due to its requirement of an API key and other general usability issues. Additionally, the PokeAPI is a lot simpler and allows for explaining concepts in a more inclusive fashion.
  • Additionally, I feel like the initial speedrun doc left out a lot of opportunities for learning in the path of being speedy. I've reintroduced some learning opportunities for the reader without sacrificing too much of the brevity.

Secondary Changes

  • Added the necessary helper files in the airbyte-cdk docs directory

Notes

  • Once we feel confident in this one, we can deprecate the old speedrun. I've given it a test run, so everything should work as expected.

@avaidyanatha avaidyanatha added the area/documentation Improvements or additions to documentation label Sep 1, 2021
@github-actions github-actions bot added the CDK Connector Development Kit label Sep 1, 2021
@marcosmarxm
Copy link
Member

marcosmarxm commented Sep 2, 2021

@avaidyanatha can you apply ./gradlew format or handle the EOL is the building? Overall LGTM!

@avaidyanatha avaidyanatha merged commit e7413de into master Sep 8, 2021
@avaidyanatha avaidyanatha deleted the abhi/evolution-is-instant branch September 8, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants