-
Notifications
You must be signed in to change notification settings - Fork 4.6k
[source-postgres] Azure client auth for postgres #57511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@vpipkt is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
not the jdbcConfig
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vpipkt let me know when this is ready to review.
I think it is ready for a look, very interested in your feedback @marcosmarxm |
/run-connector-tests
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vpipkt please check tests results. It seems some integratoin tests are failing
@marcosmarxm ok fixed, I was able to run the integration tests locally and see all passing. |
/run-connector-tests |
Running tests lets wait for results. |
What
Allow connector to authenticate via Azure Entra application registration toward
Azure Database for PostgreSQL flexible server
. This means generating a short-lived token from service principal client id and client secret, which is used to connect to the database.This is basically the same as in #50398, but toward Postgres.
See #57561
How
Update method to get password to detect and use some new configuration keys defined for this purpose. Add dependency to azure identity.
very much open for suggestions in regards to implementation
Review guide
Unclear what all needs to be done still
User Impact
End result should be no effect if not using azure auth.
Connector can authenticate to Azure flexible servers with auth token instead of local database password.
Can this PR be safely reverted and rolled back?