Skip to content

[source-postgres] Azure client auth for postgres #57511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

vpipkt
Copy link
Contributor

@vpipkt vpipkt commented Apr 8, 2025

What

Allow connector to authenticate via Azure Entra application registration toward Azure Database for PostgreSQL flexible server. This means generating a short-lived token from service principal client id and client secret, which is used to connect to the database.

This is basically the same as in #50398, but toward Postgres.

See #57561

How

Update method to get password to detect and use some new configuration keys defined for this purpose. Add dependency to azure identity.

very much open for suggestions in regards to implementation

Review guide

Unclear what all needs to be done still

User Impact

End result should be no effect if not using azure auth.

Connector can authenticate to Azure flexible servers with auth token instead of local database password.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Apr 8, 2025

@vpipkt is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

@vpipkt vpipkt temporarily deployed to community-ci-auto April 8, 2025 10:28 — with GitHub Actions Inactive
@vpipkt vpipkt changed the title Azure client auth for postgres [source-postgres] Azure client auth for postgres Apr 10, 2025
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vpipkt let me know when this is ready to review.

@vpipkt vpipkt temporarily deployed to community-ci-auto May 20, 2025 13:18 — with GitHub Actions Inactive
@vpipkt vpipkt marked this pull request as ready for review May 20, 2025 13:34
@vpipkt vpipkt requested a review from a team as a code owner May 20, 2025 13:34
@vpipkt
Copy link
Contributor Author

vpipkt commented May 20, 2025

@vpipkt let me know when this is ready to review.

I think it is ready for a look, very interested in your feedback @marcosmarxm

@marcosmarxm
Copy link
Member

marcosmarxm commented May 30, 2025

/run-connector-tests

Connector CI Tests Started

These tests will leverage Airbyte's integration test credentials.

Check job output.
Connector CI Tests job completed. See logs for details.

Copy link

vercel bot commented May 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2025 4:42pm

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vpipkt please check tests results. It seems some integratoin tests are failing

@vpipkt
Copy link
Contributor Author

vpipkt commented Jun 4, 2025

@marcosmarxm ok fixed, I was able to run the integration tests locally and see all passing.

@marcosmarxm
Copy link
Member

/run-connector-tests

@marcosmarxm
Copy link
Member

Running tests lets wait for results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants