-
Notifications
You must be signed in to change notification settings - Fork 4.6k
(Do Not Merge) Source S3 - Bumping memory on discover schema #56950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not overrided this for jobType of discover_schema
, but it looks correct based on my experience with MotherDuck and the check
operation:
airbyte/airbyte-integrations/connectors/destination-motherduck/metadata.yaml
Lines 25 to 31 in 701bc15
resourceRequirements: | |
jobSpecific: | |
- jobType: check_connection | |
resourceRequirements: | |
memory_limit: 800Mi | |
memory_request: 800Mi | |
- jobType: sync |
One thing I'm not sure of - you might? need to bump the version in order to force republish of the catalog metadata. But it might not be necessary.
I have no idea. I've been following this guide @agarctfi made to help support handle these bumps |
What
https://github.com/airbytehq/oncall/issues/7403
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?