Skip to content

(Do Not Merge) Source S3 - Bumping memory on discover schema #56950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

jnr0790
Copy link
Contributor

@jnr0790 jnr0790 commented Apr 1, 2025

What

https://github.com/airbytehq/oncall/issues/7403

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES πŸ’š
  • NO ❌

Copy link

vercel bot commented Apr 1, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
airbyte-docs βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Apr 4, 2025 3:58pm

Copy link
Collaborator

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not overrided this for jobType of discover_schema, but it looks correct based on my experience with MotherDuck and the check operation:

resourceRequirements:
jobSpecific:
- jobType: check_connection
resourceRequirements:
memory_limit: 800Mi
memory_request: 800Mi
- jobType: sync

One thing I'm not sure of - you might? need to bump the version in order to force republish of the catalog metadata. But it might not be necessary.

@jnr0790
Copy link
Contributor Author

jnr0790 commented Apr 3, 2025

I have no idea. I've been following this guide @agarctfi made to help support handle these bumps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants