Skip to content

Source Google Ads: enable additional params spec.json #5509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 19, 2021
Merged

Source Google Ads: enable additional params spec.json #5509

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf4d007
enable additioanl params spec.json
marcosmarxm Aug 18, 2021
e4a21ff
removed duplicated tests
marcosmarxm Aug 18, 2021
a365886
add docs
marcosmarxm Aug 18, 2021
e722c1f
format keen
marcosmarxm Aug 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ain/resources/config/STANDARD_SOURCE_DEFINITION/253487c0-2246-43ba-a21f-5116b20a2c50.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
"sourceDefinitionId": "253487c0-2246-43ba-a21f-5116b20a2c50",
"name": "Google Ads",
"dockerRepository": "airbyte/source-google-ads",
"dockerImageTag": "0.1.7",
"dockerImageTag": "0.1.8",
"documentationUrl": "https://docs.airbyte.io/integrations/sources/google-ads"
}
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
- sourceDefinitionId: 253487c0-2246-43ba-a21f-5116b20a2c50
name: Google Ads
dockerRepository: airbyte/source-google-ads
dockerImageTag: 0.1.7
dockerImageTag: 0.1.8
documentationUrl: https://docs.airbyte.io/integrations/sources/google-ads
- sourceDefinitionId: fdc8b827-3257-4b33-83cc-106d234c34d4
name: Google Adwords (Deprecated)
Expand Down
1 change: 0 additions & 1 deletion airbyte-integrations/bases/base-python/base_python/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@

from base_python.catalog_helpers import CatalogHelper
from base_python.cdk.abstract_source import AbstractSource

# Separate the SDK imports so they can be moved somewhere else more easily
from base_python.cdk.streams.auth.core import HttpAuthenticator
from base_python.cdk.streams.auth.oauth import Oauth2Authenticator
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-google-ads/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ RUN pip install .

ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.7
LABEL io.airbyte.version=0.1.8
LABEL io.airbyte.name=airbyte/source-google-ads
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-google-ads/source_google_ads/spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"title": "Google Ads Spec",
"type": "object",
"required": ["credentials", "start_date", "customer_id"],
"additionalProperties": false,
"additionalProperties": true,
"properties": {
"credentials": {
"type": "object",
Expand Down