Skip to content

📝 🎉 Source Dixa: Migrated to CI Sandbox, refactored code structure for future support #5367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Aug 18, 2021
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/publish-command.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ jobs:
DESTINATION_PUBSUB_TEST_CREDS: ${{ secrets.DESTINATION_PUBSUB_TEST_CREDS }}
DESTINATION_KVDB_TEST_CREDS: ${{ secrets.DESTINATION_KVDB_TEST_CREDS }}
DRIFT_INTEGRATION_TEST_CREDS: ${{ secrets.DRIFT_INTEGRATION_TEST_CREDS }}
SOURCE_DIXA_TEST_CREDS: ${{ secrets.SOURCE_DIXA_TEST_CREDS }}
EXCHANGE_RATES_TEST_CREDS: ${{ secrets.EXCHANGE_RATES_TEST_CREDS }}
FACEBOOK_MARKETING_TEST_INTEGRATION_CREDS: ${{ secrets.FACEBOOK_MARKETING_TEST_INTEGRATION_CREDS }}
FACEBOOK_MARKETING_API_TEST_INTEGRATION_CREDS: ${{ secrets.FACEBOOK_MARKETING_API_TEST_INTEGRATION_CREDS }}
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-command.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ jobs:
DESTINATION_PUBSUB_TEST_CREDS: ${{ secrets.DESTINATION_PUBSUB_TEST_CREDS }}
DESTINATION_KVDB_TEST_CREDS: ${{ secrets.DESTINATION_KVDB_TEST_CREDS }}
DRIFT_INTEGRATION_TEST_CREDS: ${{ secrets.DRIFT_INTEGRATION_TEST_CREDS }}
SOURCE_DIXA_TEST_CREDS: ${{ secrets.SOURCE_DIXA_TEST_CREDS }}
EXCHANGE_RATES_TEST_CREDS: ${{ secrets.EXCHANGE_RATES_TEST_CREDS }}
FACEBOOK_MARKETING_TEST_INTEGRATION_CREDS: ${{ secrets.FACEBOOK_MARKETING_TEST_INTEGRATION_CREDS }}
FACEBOOK_MARKETING_API_TEST_INTEGRATION_CREDS: ${{ secrets.FACEBOOK_MARKETING_API_TEST_INTEGRATION_CREDS }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
"sourceDefinitionId": "0b5c867e-1b12-4d02-ab74-97b2184ff6d7",
"name": "Dixa",
"dockerRepository": "airbyte/source-dixa",
"dockerImageTag": "0.1.0",
"dockerImageTag": "0.1.1",
"documentationUrl": "https://docs.airbyte.io/integrations/sources/dixa"
}
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@
- sourceDefinitionId: 0b5c867e-1b12-4d02-ab74-97b2184ff6d7
name: Dixa
dockerRepository: airbyte/source-dixa
dockerImageTag: 0.1.0
dockerImageTag: 0.1.1
documentationUrl: https://docs.airbyte.io/integrations/sources/dixa
- sourceDefinitionId: e7eff203-90bf-43e5-a240-19ea3056c474
name: Typeform
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-dixa/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ RUN pip install .
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.0
LABEL io.airbyte.version=0.1.1
LABEL io.airbyte.name=airbyte/source-dixa
Original file line number Diff line number Diff line change
Expand Up @@ -14,20 +14,13 @@ tests:
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
# TODO uncomment this block to specify that the tests should assert the connector outputs the records provided in the input file a file
# expect_records:
# path: "integration_tests/expected_records.txt"
# extra_fields: no
# exact_order: no
# extra_records: yes
timeout_seconds: 1200
incremental:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
# future_state_path: "integration_tests/abnormal_state.json"
# We skip the full_refresh test because of unusual behaviour in the Dixa API.
# We observed cases where a record was updated without the updated_at value changing.
# See the thread below for further information:
# https://airbytehq.slack.com/archives/C01VDDEGL7M/p1625319909273300
# full_refresh:
# - config_path: "secrets/config.json"
# configured_catalog_path: "integration_tests/configured_catalog.json"
future_state_path: "integration_tests/abnormal_state.json"
timeout_seconds: 1200
full_refresh:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
timeout_seconds: 1200
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"conversation_export": {
"updated_at": 9999999999999
"updated_at": 1628748165699
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,4 @@

@pytest.fixture(scope="session", autouse=True)
def connector_setup():
""" This fixture is a placeholder for external resources that acceptance test might require."""
# TODO: setup test dependencies if needed. otherwise remove the TODO comments
yield
# TODO: clean up test dependencies

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
{
"streams": [
{
"sync_mode": "incremental",
"destination_sync_mode": "append",
"cursor_field": ["updated_at"],
"stream": {
"name": "conversation_export",
"json_schema": {},
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"default_cursor_field": ["updated_at"],
"source_defined_primary_key": [["id"]],
"json_schema": {}
}
"source_defined_primary_key": [["id"]]
},
"sync_mode": "incremental",
"cursor_field": ["updated_at"],
"destination_sync_mode": "append"
}
]
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"start_timestamp": 1625263200000,
"batch_size": 1
"api_token": "TOKEN",
"start_date": "2020-01-01",
"batch_size": "31"
}
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
{
"fix-me": "TODO"
"api_token": "TOKEN",
"start_date": "2020-01-01",
"batch_size": "31"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"todo-stream-name": {
"todo-field-name": "value"
"conversation_export": {
"updated_at": 1628748165633
}
}
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
{
"type": "object",
"type": ["null", "object"],
"required": ["id", "created_at", "initial_channel", "requester_id"],
"properties": {
"id": {
"type": "integer"
"type": ["null", "integer"]
},
"created_at": {
"type": "integer"
"type": ["null", "integer"]
},
"initial_channel": {
"type": "string"
"type": ["null", "string"]
},
"requester_id": {
"type": "string"
"type": ["null", "string"]
},
"requester_name": {
"type": ["null", "string"]
Expand Down Expand Up @@ -42,9 +42,9 @@
"type": ["null", "string"]
},
"ratings": {
"type": "array",
"type": ["null", "array"],
"items": {
"type": "object",
"type": ["null", "object"],
"properties": {
"rating_score": {
"type": ["null", "integer"]
Expand Down Expand Up @@ -142,13 +142,13 @@
"tags": {
"type": ["null", "array"],
"items": {
"type": "string"
"type": ["null", "string"]
}
},
"conversation_wrapup_notes": {
"type": ["null", "array"],
"items": {
"type": "string"
"type": ["null", "string"]
}
},
"transferee_name": {
Expand Down
Loading