Skip to content

Destination-S3: Missing nested IT cases #52584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

johnny-schmidt
Copy link
Contributor

What

Remaining test cases here.

This just hits some edge cases I know tripped us up in the release. I think this gets everything that is also effectively in the legacy dats.

@johnny-schmidt johnny-schmidt requested a review from a team as a code owner January 27, 2025 23:09
Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 6:50pm

Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

union types D: (thanks for writing these tests!)

@johnny-schmidt johnny-schmidt force-pushed the jschmidt/load-cdk/nested-test-cases branch from 3738eec to f1c5f91 Compare January 30, 2025 18:44
@johnny-schmidt johnny-schmidt enabled auto-merge (squash) January 30, 2025 18:44
@johnny-schmidt johnny-schmidt merged commit e2edfd7 into master Jan 30, 2025
29 checks passed
@johnny-schmidt johnny-schmidt deleted the jschmidt/load-cdk/nested-test-cases branch January 30, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants