-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Refactor dbt transformation entrypoint script #5076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor dbt transformation entrypoint script #5076
Conversation
echo "Running: dbt $@" | ||
dbt $@ | ||
else | ||
dbt $@ --profile normalize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we use the --profile
flag: https://github.com/dbt-labs/dbt/blob/35645a7233f4d32167d4db4a6066297cd8f79514/core/dbt/main.py#L290
We don't need to manipulate our profiles.yml to match with the declared profile in the dbt_project.yml
file anymore... So it closes #4734
POSITIONAL+=("$1") | ||
shift | ||
;; | ||
--project-dir=*|--project-dir) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confusing users that were using --project-dir <dir>
instead of --project-dir=<dir>
the script now handles both, see https://airbytehq.slack.com/archives/C021JANJ6TY/p1627511090382200?thread_ts=1627506369.378200&cid=C021JANJ6TY
/test connector=connectors/destination-postgres
|
airbyte-workers/src/main/resources/dbt_transformation_entrypoint.sh
Outdated
Show resolved
Hide resolved
…ormation-entrypoint
What
This makes it more robust at overriding the mandatory options of
--project-dir
and--profiles-dir
that are passed to dbtcloses #4734