Skip to content

add destinations, destinationSpecifications, and destinationImplementations resources to API #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 14, 2020
Merged

add destinations, destinationSpecifications, and destinationImplementations resources to API #49

merged 4 commits into from
Aug 14, 2020

Conversation

cgardens
Copy link
Contributor

What

  • add destinations, destinationSpecifications, and destinationImplementations resources to API. these are almost exact mirrors of their source counterparts. this PR was primarily a find and replace job.

michel-tricot
michel-tricot approved these changes Aug 13, 2020
View reviewed changes
dataline-server/src/main/java/io/dataline/server/apis/ConfigurationApi.java Outdated
import io.dataline.server.handlers.SourceSpecificationsHandler;
import io.dataline.server.handlers.SourcesHandler;
import io.dataline.server.handlers.WorkspacesHandler;
import io.dataline.server.handlers.*;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2020-08-13 at 10 43 05 AM
@sherifnada @jrhizor FYI

Copy link
Contributor

@jrhizor jrhizor Aug 13, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated in my config as of now 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. done.

...line-server/src/main/java/io/dataline/server/handlers/DestinationImplementationsHandler.java Outdated
private final ConfigPersistence configPersistence;
private final IntegrationSchemaValidation validator;

public DestinationImplementationsHandler(ConfigPersistence configPersistence) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

...-server/src/test/java/io/dataline/server/handlers/DestinationImplementationsHandlerTest.java Outdated

@BeforeEach
void setUp() {
configPersistence = ConfigPersistenceImpl.getTest();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use a mock instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed. done.

@cgardens cgardens force-pushed the cgardens/endpoints4 branch from bb659c5 to c2e91b8 Compare August 14, 2020 00:10
Base automatically changed from cgardens/endpoints4 to master August 14, 2020 14:21
@cgardens cgardens force-pushed the cgardens/endpoints5 branch from e0ab902 to fce475b Compare August 14, 2020 14:21
@cgardens cgardens merged commit a070aaf into master Aug 14, 2020
@cgardens cgardens deleted the cgardens/endpoints5 branch August 14, 2020 14:32
davydov-d added a commit that referenced this pull request May 17, 2022
@davydov-d
#12486 and #49 from alpha-beta-issues fixes
c37fe3b
davydov-d added a commit that referenced this pull request May 23, 2022
@davydov-d
#12486 #49-alpha-beta-issues PR comment fixes
b34f112
davydov-d added a commit that referenced this pull request May 25, 2022
@davydov-d @octavia-squidington-iii
#12486 and #49 from alpha-beta-issues fixes (#12914)
a3f6a18 
* #12486 and #49 from alpha-beta-issues fixes

* test updates for #airbyte/12486 and #alpha-beta-issues/49

* #12486 #49-alpha-beta-issues PR comment fixes

* #12486 doc upd: add note on use of custom queries

* auto-bump connector version

Co-authored-by: Octavia Squidington III <[email protected]>
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request May 25, 2022
Merged
jscottpolevault pushed a commit to jscottpolevault/airbyte that referenced this pull request Jun 1, 2022
@davydov-d @octavia-squidington-iii
airbytehq#12486 and airbytehq#49 from alpha-beta-issues fixes (airbyt…
985e2c8 
…ehq#12914)

* airbytehq#12486 and airbytehq#49 from alpha-beta-issues fixes

* test updates for #airbyte/12486 and #alpha-beta-issues/49

* airbytehq#12486 airbytehq#49-alpha-beta-issues PR comment fixes

* airbytehq#12486 doc upd: add note on use of custom queries

* auto-bump connector version

Co-authored-by: Octavia Squidington III <[email protected]>
marcosmarxm pushed a commit that referenced this pull request Jun 24, 2024
@github-actions
Merge pull request #49 from airbytehq/master
ff9ae2d 
Fork Sync: Update from parent repository
@rskrishnar rskrishnar mentioned this pull request Mar 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhizor jrhizor jrhizor approved these changes

@michel-tricot michel-tricot michel-tricot approved these changes

@sherifnada sherifnada sherifnada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cgardens @jrhizor @michel-tricot @sherifnada