Skip to content

🎉 New Source: DataScope #4636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 38 commits into from
Closed

🎉 New Source: DataScope #4636

wants to merge 38 commits into from

Conversation

agrass
Copy link
Contributor

@agrass agrass commented Jul 8, 2021

What

Connector for source DataScope (https://mydatascope.com)

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

Connector checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Secrets are annotated with airbyte_secret in the connector's spec
  • Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
  • Unit & integration tests added as appropriate (and are passing)
    • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • /test connector=connectors/<name> command as documented here is passing.
    • Community members can skip this, Airbyters will run this for you.
  • Code reviews completed
  • Documentation updated
    • README.md
    • docs/SUMMARY.md if it's a new connector
    • Created or updated reference docs in docs/integrations/<source or destination>/<name>.
    • Changelog in the appropriate page in docs/integrations/.... See changelog example
    • docs/integrations/README.md contains a reference to the new connector
    • Build status added to build page
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified

Connector Generator checklist

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.


This change is Reviewable

@github-actions github-actions bot added the area/connectors Connector related issues label Jul 8, 2021
@avaidyanatha avaidyanatha changed the title New Source: DataScope 🎉 New Source: DataScope Jul 9, 2021
@marcosmarxm
Copy link
Member

Thanks @agrass for the contribution! Do you think this is ready to review or need any assistance or feedback in the current work?

@sherifnada sherifnada self-requested a review July 9, 2021 18:33
@agrass
Copy link
Contributor Author

agrass commented Jul 4, 2022

Hello @marcosmarxm! What is the reason for the close? Is it possible to reopen this? What is missing to release the first version? I received some comments and I have already replied, but I am not sure about the next step. Thanks for the help.

@marcosmarxm marcosmarxm reopened this Jul 5, 2022
@marcosmarxm
Copy link
Member

Totally sorry @agrass Do you mind resolving the conflicts and share the integration tests output for this connectors so we can merge it?

@agrass agrass requested a review from a team as a code owner August 25, 2022 16:00
@grishick
Copy link
Contributor

@agrass thank you for the contribution! Looks like your editor made a whole bunch of formatting changes (adding spaces and lines) in several unrelated files. Could you clean those up and update the PR?

@agrass
Copy link
Contributor Author

agrass commented Aug 25, 2022

@agrass thank you for the contribution! Looks like your editor made a whole bunch of formatting changes (adding spaces and lines) in several unrelated files. Could you clean those up and update the PR?

Thanks for letting me know, I'm going to fix that

@marcosmarxm
Copy link
Member

Closed in favor of #18725 which uses the low-code CDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment