-
Notifications
You must be signed in to change notification settings - Fork 4.6k
🎉 New Source: DataScope #4636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 New Source: DataScope #4636
Conversation
Thanks @agrass for the contribution! Do you think this is ready to review or need any assistance or feedback in the current work? |
Hello @marcosmarxm! What is the reason for the close? Is it possible to reopen this? What is missing to release the first version? I received some comments and I have already replied, but I am not sure about the next step. Thanks for the help. |
Totally sorry @agrass Do you mind resolving the conflicts and share the integration tests output for this connectors so we can merge it? |
@agrass thank you for the contribution! Looks like your editor made a whole bunch of formatting changes (adding spaces and lines) in several unrelated files. Could you clean those up and update the PR? |
Thanks for letting me know, I'm going to fix that |
Closed in favor of #18725 which uses the low-code CDK. |
What
Connector for source DataScope (https://mydatascope.com)
Pre-merge Checklist
Expand the checklist which is relevant for this PR.
Connector checklist
airbyte_secret
in the connector's spec./gradlew :airbyte-integrations:connectors:<name>:integrationTest
./test connector=connectors/<name>
command as documented here is passing.README.md
docs/SUMMARY.md
if it's a new connectordocs/integrations/<source or destination>/<name>
.docs/integrations/...
. See changelog exampledocs/integrations/README.md
contains a reference to the new connector/publish
command described hereConnector Generator checklist
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changesThis change is