Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(airbyte-cdk): Fix error in incremental sync docs #45194

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

tolik0
Copy link
Contributor

@tolik0 tolik0 commented Sep 6, 2024

What

This PR fixes an issue in the incremental sync documentation where a missing escape character caused an failed Vercel build.

How

Escapes the < symbol in the incremental-syncs.md file to prevent a formatting error and correctly display the partition limit (<10k).

User Impact

The documentation now correctly renders the partition limit as "<10k". No negative side effects.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 2:35pm

@tolik0 tolik0 marked this pull request as ready for review September 6, 2024 14:35
@tolik0 tolik0 self-assigned this Sep 6, 2024
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Sep 6, 2024
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tolik0 tolik0 merged commit caa12ab into master Sep 6, 2024
33 checks passed
@tolik0 tolik0 deleted the tolik0/airbyte-cdk/global-cursor-fix-docs branch September 6, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants