Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(source-shopify): update CDK to v5 #45190

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

artem1205
Copy link
Collaborator

What

update CDK to v5

How

  • bump CDK version
  • replace airbyte_protocol.models with airbyte_cdk.models
  • fix unit test

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

[skip ci]

Signed-off-by: Artem Inzhyyants <[email protected]>
@artem1205 artem1205 self-assigned this Sep 6, 2024
Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2024 3:09pm

Signed-off-by: Artem Inzhyyants <[email protected]>
Signed-off-by: Artem Inzhyyants <[email protected]>
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Sep 6, 2024
Signed-off-by: Artem Inzhyyants <[email protected]>
@artem1205 artem1205 marked this pull request as ready for review September 6, 2024 15:09
@artem1205 artem1205 requested a review from a team September 6, 2024 15:09
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CATs pass

@artem1205
Copy link
Collaborator Author

artem1205 commented Sep 9, 2024

/approve-regression-tests Regression tests failed only on schema match (null fields were removed )

Check job output.

✅ Approving regression tests

@artem1205 artem1205 merged commit 7ffcd3d into master Sep 9, 2024
38 checks passed
@artem1205 artem1205 deleted the artem1205/source-shopify-cdk-update branch September 9, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/shopify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants