Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(source-declarative-manifest): fix models #45088

Merged
merged 4 commits into from
Sep 3, 2024
Merged

fix(source-declarative-manifest): fix models #45088

merged 4 commits into from
Sep 3, 2024

Conversation

artem1205
Copy link
Contributor

What

Fix new protocol models

How

use Serializer

Review guide

  1. airbyte-integrations/connectors/source-declarative-manifest/source_declarative_manifest/run.py

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel Vercel
Copy link

vercel bot commented Sep 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Sep 3, 2024 8:34am

@artem1205 artem1205 self-assigned this Sep 2, 2024
@artem1205 artem1205 marked this pull request as ready for review September 2, 2024 16:39
@artem1205
Copy link
Contributor Author

@alafanechere ,
CI fails on QA check:

source-declarative-manifest - ❌ Failed - Connectors must have a changelog entry for each version:

But I cannot find any docs for this connector.
How can we merge this?

@alafanechere
Copy link
Contributor

@alafanechere , CI fails on QA check:

source-declarative-manifest - ❌ Failed - Connectors must have a changelog entry for each version:

But I cannot find any docs for this connector. How can we merge this?

I think the changelog is here: https://github.com/airbytehq/airbyte/blob/master/docs/integrations/sources/low-code.md#L1

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Sep 2, 2024
@artem1205
Copy link
Contributor Author

@alafanechere,
found another comment in metadata:

# This version should not be updated manually - it is updated by the CDK release workflow.

What should we do?

girarda
girarda approved these changes Sep 2, 2024
View reviewed changes
docs/integrations/sources/low-code.md Outdated
| 0.78.9 | 2024-04-04 | [36834](https://github.com/airbytehq/airbyte/pull/36834) | Update CDK dependency to version 0.78.9 (before new publishing flow) |
| Version | Date | Pull Request | Subject |
|:--------|:-----------|:---------------------------------------------------------------------------------------------|:---------------------------------------------------------------------|
| 5.0.1 | 2024-09-02 | [45088](https://github.com/airbytehq/airbyte/pull/45088) | Bump CDK version to 5.0.1 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CDK version is bumped to 5.0.0.

airbyte-integrations/connectors/source-declarative-manifest/pyproject.toml Outdated
@@ -3,7 +3,7 @@ requires = ["poetry-core>=1.0.0"]
build-backend = "poetry.core.masonry.api"

[tool.poetry]
version = "5.0.0"
version = "5.0.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think 5.0.0 has been released so we should be good to keep the same version number

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edit: it's been released on pypi, but not docker :/

@alafanechere
Copy link
Contributor

@alafanechere, found another comment in metadata:

# This version should not be updated manually - it is updated by the CDK release workflow.

What should we do?

Oh yes. Let's revert the bump version changes. We can ignore failing QA checks related to version increment / changelog. I'll approve and merge + log an issue to handle this case in QA checks.

@octavia-squidington-iii octavia-squidington-iii removed the area/documentation Improvements or additions to documentation label Sep 3, 2024
@alafanechere
Copy link
Contributor

/approve-and-merge reason=source-declarative-manifest version bump is meant to happen on manual CDK release

@octavia-approvington
Copy link
Contributor

You did it!
finish line

@octavia-approvington octavia-approvington merged commit fa6aa2b into master Sep 3, 2024
32 of 36 checks passed
@octavia-approvington octavia-approvington deleted the artem1205/airbyte-cdk-fix-declarative-manifest branch September 3, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girarda girarda girarda approved these changes

@octavia-approvington octavia-approvington octavia-approvington approved these changes

@alafanechere alafanechere Awaiting requested review from alafanechere

Assignees

@artem1205 artem1205

Labels
area/connectors Connector related issues connectors/source/declarative-manifest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@artem1205 @alafanechere @octavia-approvington @girarda @octavia-squidington-iii