🐛 Source Klaviyo: have region also be a number #44930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
maxi297
force-pushed
the
oncall-6353/klaviyo-region-can-be-a-number
branch
from
07b7c1d to
f740adb
Compare
girarda
approved these changes
Aug 30, 2024
and thank you for writing a test| assert len(output.records) == 1 | ||
|
|
||
| @HttpMocker() | ||
| def test_given_region_is_number_when_read_then_cast_as_string(self, http_mocker: HttpMocker) -> None: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Addresses https://github.com/airbytehq/oncall/issues/6353
How
At first, we thought of adding a type to the schema. That being said, this is a breaking change.
Hence, we decided to add normalization to the profiles stream. This might slow down a bit the connector but we avoid a breaking change. Eventually, we might want to switch to this solution
User Impact
The users that have some
attributes.location.regionas a number will now have successful syncs if the destination had typing issues.Can this PR be safely reverted and rolled back?