Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source-clazar: incremental APIs for online streams #44855

Merged
merged 10 commits into from
Aug 29, 2024
Merged

source-clazar: incremental APIs for online streams #44855

merged 10 commits into from
Aug 29, 2024

Conversation

prashant-mittal9
Copy link
Contributor

What

  • Supporting incremental syncs for Buyers/Listings/Contracts/Opportunities/Private Offers

How

  • Utilizing last_modified_at timestamp with filtering

Review guide

  1. manifest.yaml file generated from the connector builder changes

User Impact

  • Faster sync jobs as the the number of rows that will be synced will be considerably less

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel Vercel
Copy link

vercel bot commented Aug 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 8:26pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/clazar labels Aug 28, 2024
@prashant-mittal9
Merge branch 'master' of github.com:prashant-mittal9/airbyte into pra…
dc225b9 
…shant-mittal9/source-clazar-online-incremental-api
@natikgadzhi natikgadzhi temporarily deployed to community-ci-auto August 28, 2024 18:18 — with GitHub Actions Inactive
@natikgadzhi natikgadzhi temporarily deployed to community-ci-auto August 28, 2024 18:18 — with GitHub Actions Inactive
natikgadzhi
natikgadzhi reviewed Aug 29, 2024
View reviewed changes
Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to merge and approve this as minor version bump, or you'd have to add breaking change documentation.

Guide here https://docs.airbyte.com/contributing-to-airbyte/change-cdk-connector#breaking-changes-to-connectors

If you choose to go for major version upgrade, you would also need to have a section in docs describing the scope of the change.

Honestly, just take the suggestion and call it 0.4. and let's ship.

@natikgadzhi natikgadzhi merged commit 23faec3 into airbytehq:master Aug 29, 2024
28 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natikgadzhi natikgadzhi Awaiting requested review from natikgadzhi

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/clazar
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prashant-mittal9 @natikgadzhi @octavia-squidington-iii