Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[source-mongodb] use escaped dot in wass streamlist #44846

Merged
merged 7 commits into from
Aug 28, 2024

Conversation

xiaohansong
Copy link
Contributor

What

non wass (incremental only) is still using escaped dot. Thus with previous PR #44839 we feed incorrect collection to DBZ (empty list), causing we are sending change data on unselected streams, which got rejected by platform. Reverting previous change and apply the change to the correct place.

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@xiaohansong xiaohansong requested a review from a team as a code owner August 28, 2024 06:35
Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 6:45am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mongodb-v2 labels Aug 28, 2024
@octavia-squidington-iii octavia-squidington-iii removed the area/documentation Improvements or additions to documentation label Aug 28, 2024
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Aug 28, 2024
@xiaohansong xiaohansong requested a review from akashkulk August 28, 2024 06:57
@xiaohansong xiaohansong enabled auto-merge (squash) August 28, 2024 06:58
@xiaohansong xiaohansong merged commit 6cbba8d into master Aug 28, 2024
38 checks passed
@xiaohansong xiaohansong deleted the xiaohan/mongostate branch August 28, 2024 14:46
@xiaohansong xiaohansong requested review from akashkulk and a team August 28, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mongodb-v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants