Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Incomplete) First Cut Load CDK with E2E Destination #44822

Merged
merged 7 commits into from
Aug 30, 2024

Conversation

johnny-schmidt
Copy link
Contributor

WIP Draft PR for the new CDK

semi-complete whimsical breakdown here

Copy link

vercel bot commented Aug 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2024 6:37pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues CDK Connector Development Kit connectors/destination/e2e-test labels Aug 27, 2024

testImplementation("org.jetbrains.kotlinx:kotlinx-coroutines-test:1.7.1")
implementation "org.jetbrains.kotlin:kotlin-reflect:2.0.0"
//testImplementation project(':airbyte-cdk:bulk:toolkits:bulk-cdk-toolkit-extract-jdbc')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for not pushing those into the deps.toml

@johnny-schmidt johnny-schmidt force-pushed the issue-9361/load-cdk-with-e2e-dest branch from 050fbd9 to a7cd06c Compare August 28, 2024 23:17
@johnny-schmidt johnny-schmidt marked this pull request as ready for review August 30, 2024 17:08
@johnny-schmidt johnny-schmidt requested a review from a team as a code owner August 30, 2024 17:08
@johnny-schmidt johnny-schmidt changed the title (WIP) First Cut Load CDK with E2E Destination (Incomplete) First Cut Load CDK with E2E Destination Aug 30, 2024
@johnny-schmidt johnny-schmidt force-pushed the issue-9361/load-cdk-with-e2e-dest branch from 7673c0b to 8434586 Compare August 30, 2024 17:22
@octavia-squidington-iii octavia-squidington-iii removed the area/connectors Connector related issues label Aug 30, 2024
@johnny-schmidt johnny-schmidt merged commit 89f2db4 into master Aug 30, 2024
32 checks passed
@johnny-schmidt johnny-schmidt deleted the issue-9361/load-cdk-with-e2e-dest branch August 30, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants