bulk-cdk-toolkit-extract-jdbc: add namespaceKind constant #44767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
xiaohansong
reviewed
Aug 27, 2024
...dk/bulk/toolkits/extract-jdbc/src/main/kotlin/io/airbyte/cdk/discover/JdbcMetadataQuerier.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This came to be after thinking about #44607 . Fundamentally, there's an ambiguity whether
namespacerefers to a JDBC schema or a JDBC catalog. This PR makes it configurable via a micronaut property. For example, for source-mysql-v2, addairbyte.connector.extract.jdbc.namespace-kind: catalogto the resource fileapplication.yml. See airbyte-enterprise for other examples of similarly configured properties: https://github.com/airbytehq/airbyte-enterprise/blob/master/airbyte-integrations/connectors/source-firetruck/src/main/resources/application.ymlHow
Adds a
namespaceKindfield to theConstantsMicronaut singleton. Makes theJdbcMetadataQuerier.Factorydepend on that singleton.Review guide
The first commit contains the actual change. The next commit moves the
Constantsobject out of thereadand into thejdbcmodule but otherwise is a purely mechanical change.User Impact
None
Can this PR be safely reverted and rolled back?