MSSQL and debezium improvements #44759
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
| @@ -181,7 +181,7 @@ class DebeziumRecordIterator<T>( | |||
| hasSnapshotFinished = !changeEventWithMetadata.isSnapshotEvent | |||
|
|
|||
| if (isEventLogged) { | |||
| val source: JsonNode? = changeEventWithMetadata.eventValueAsJson()["source"] | |||
| val source: JsonNode? = changeEventWithMetadata.eventValueAsJson?.get("source") | |||
There was a problem hiding this comment.
kotlin doesn't have ?[] unfortunately
octavia-squidington-iii
added
the
area/documentation
…entexception-argument-content-is-null-after-adding-primary-key
|
@evantahler I'd like to add a troubleshooting doc for mssql, similarly to what we have in other connectors (e.g). |
|
@rodireich - you've got to add the new doc to the sidebar nav as well. I can help if you get stuck! |
…entexception-argument-content-is-null-after-adding-primary-key
…entexception-argument-content-is-null-after-adding-primary-key
| event | ||
| .value() | ||
| ?.let { Jsons.deserialize(it) } | ||
| .also { it ?: LOGGER.warn { "Event value is null $event" } } |
There was a problem hiding this comment.
This could spam the logs.
There was a problem hiding this comment.
If we get to the situation where value or key are null then something is seriously misoncifugred, as was the case on the oncall ticket.
I'd rather know what the malformed debezium event looks like. I couldn't figure out the root cause until I was able to get to this information.
...es/src/main/kotlin/io/airbyte/cdk/integrations/debezium/internals/ChangeEventWithMetadata.kt
Outdated
Show resolved
Hide resolved
...es/src/main/kotlin/io/airbyte/cdk/integrations/debezium/internals/ChangeEventWithMetadata.kt
Show resolved
Hide resolved
...ces/src/main/kotlin/io/airbyte/cdk/integrations/debezium/internals/DebeziumRecordIterator.kt
Show resolved
Hide resolved
...src/test/kotlin/io/airbyte/cdk/integrations/debezium/internals/DebeziumRecordIteratorTest.kt
Show resolved
Hide resolved
…entexception-argument-content-is-null-after-adding-primary-key
|
/publish-java-cdk dry-run=true
|
|
/publish-java-cdk
|
rodireich
deleted the
6192-db-sources-mssql-javalangillegalargumentexception-argument-content-is-null-after-adding-primary-key
branch
What
A few issues in debezium and mssql were discovered as a result of https://github.com/airbytehq/oncall/issues/6192 .
op: rwhich is can only be part of an initial snapshot.This PR deals with the discoveries and adds a new troubleshooting page for the root cause of the oncall issue.