Skip to content

Migrate ssh tunneling and source config out of core config #44558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

johnny-schmidt
Copy link
Contributor

Only some destinations have any use for this. I'd prefer to be able to mix it in as needed.

Also: a good future improvement would be to make corresponding user-facing json spec mixins for these, maybe with dedicated factory methods, so that implementors only have to grab what they need.

@johnny-schmidt johnny-schmidt requested review from a team as code owners August 22, 2024 17:27
Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Aug 22, 2024 5:27pm

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Aug 22, 2024
Copy link
Contributor

@postamar postamar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@johnny-schmidt johnny-schmidt merged commit 194eba0 into master Aug 22, 2024
31 checks passed
@johnny-schmidt johnny-schmidt deleted the issue-9441/core-cdk-config-less-opinionated branch August 22, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants