Skip to content

🐛 migrate-to-manifest-only: conditionally propagate $parameters when resolving manifest #44557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 22, 2024
Merged

🐛 migrate-to-manifest-only: conditionally propagate $parameters when resolving manifest #44557

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
74e2e2b
fixed schemas and migration script
ChristoGrab Aug 21, 2024
9fb73b2
add type to manifest
ChristoGrab Aug 22, 2024
92f1843
Merge branch 'christo/fix-migrate-to-inline_schemas' into christo/fix…
ChristoGrab Aug 22, 2024
48e2733
chore: propagate only for valid components
ChristoGrab Aug 22, 2024
39b1e5d
chore: remove migration script
ChristoGrab Aug 22, 2024
b067aaf
format and changelog
ChristoGrab Aug 22, 2024
0b88c21
Merge branch 'master' into christo/fix-parameters-propagation
ChristoGrab Aug 22, 2024
b4a0ba9
Update airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connector…
natikgadzhi Aug 22, 2024
453b847
Update airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connector…
ChristoGrab Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...onnectors/pipelines/pipelines/airbyte_ci/connectors/migrate_to_inline_schemas/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ async def _run(self) -> StepResult:
_update_inline_schema(schema_loader, json_streams, stream_name)

write_yaml(data, manifest_path)
await format_prettier([manifest_path], logger=logger)
# await format_prettier([manifest_path], logger=logger)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out the formatting as it was causing the command to hang regardless of success or failure.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's tolerable if you just do format fix all separately before pushing up PRs. Single responsibility principle!


for json_stream in json_streams.values():
logger.info(f" !! JSON schema not found: {json_stream.name}")
Expand Down
Loading
Loading