Skip to content

airbyte-ci: do not push latest tag for release candidates #44551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alafanechere
Copy link
Contributor

What

Closes https://github.com/airbytehq/airbyte-internal-issues/issues/9403
When a connector is a release candidate it will have the releases.isReleaseCandidate flag set to true in its metadata.yaml.
We don't want to publish the latest tag when the connector is a RC.

How

Tweak the publish pipeline to conditionnaly publish the latest tag according to the metadata content.

@alafanechere alafanechere requested a review from a team August 22, 2024 13:27
Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Aug 22, 2024 4:22pm

Copy link
Contributor Author

alafanechere commented Aug 22, 2024

@alafanechere alafanechere force-pushed the augustin/08-22-airbyte-ci_do_not_push_latest_tag_for_release_candidates branch 2 times, most recently from b697480 to f8fc431 Compare August 22, 2024 13:31
Copy link
Contributor

@clnoll clnoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alafanechere alafanechere force-pushed the augustin/08-22-airbyte-ci_do_not_push_latest_tag_for_release_candidates branch from f8fc431 to 24582d2 Compare August 22, 2024 15:38
Copy link
Contributor Author

alafanechere commented Aug 22, 2024

Merge activity

  • Aug 22, 12:07 PM EDT: @alafanechere started a stack merge that includes this pull request via Graphite.
  • Aug 22, 12:22 PM EDT: Graphite rebased this pull request as part of a merge.
  • Aug 22, 12:43 PM EDT: @alafanechere merged this pull request with Graphite.

@alafanechere alafanechere changed the base branch from augustin/08-21-metadata-service_orchestrator_change_metadata_upload_logic_for_release_candidates to graphite-base/44551 August 22, 2024 16:09
@alafanechere alafanechere changed the base branch from graphite-base/44551 to master August 22, 2024 16:19
@alafanechere alafanechere force-pushed the augustin/08-22-airbyte-ci_do_not_push_latest_tag_for_release_candidates branch from 24582d2 to ab184dd Compare August 22, 2024 16:21
@alafanechere alafanechere merged commit 66b39a4 into master Aug 22, 2024
33 checks passed
@alafanechere alafanechere deleted the augustin/08-22-airbyte-ci_do_not_push_latest_tag_for_release_candidates branch August 22, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants