metadata orchestrator: set top-level lanugage field from tags #44466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @erohmensing and the rest of your teammates on |
|
@bnchrch If we like this, once we merge it, can you help me run a backfill of |
bnchrch
requested changes
Aug 21, 2024
airbyte-ci/connectors/metadata_service/orchestrator/orchestrator/assets/registry_entry.py
Show resolved
Hide resolved
airbyte-ci/connectors/metadata_service/orchestrator/tests/test_registry.py
Show resolved
Hide resolved
bnchrch
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Close https://github.com/airbytehq/airbyte-internal-issues/issues/9358
Set a top-level
languagekey on the registry entry so that we can smoothly consume this information in the platform. This is a temporary solution - we should migrate this info to top-level in the metadata file itselfCan this PR be safely reverted and rolled back?