Skip to content

[ISSUE 9173] add ERD files for source-facebook-marketing #44449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

maxi297
Copy link
Contributor

@maxi297 maxi297 commented Aug 20, 2024

What

Addresses https://github.com/airbytehq/airbyte-internal-issues/issues/9173 for source-facebook-marketing

How

By running airbyte-ci --name=source-facebook-marketing generate-erd

The publish has been done as part of the airbyte-ci command executed locally.

Some relationships have been confirmed for this one for demo purposes.

User Impact

ERD is now available on https://dbdocs.io/airbyteio/source-facebook-marketing

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 2:56pm

@maxi297
Copy link
Contributor Author

maxi297 commented Aug 20, 2024

@girarda do you see any value in having the discovered catalog used for the generation? It feels like this can be retrieved by doing a discover but it could help debugging (for example, to understand if a stream has been added since the last generation)

@girarda
Copy link
Contributor

girarda commented Aug 20, 2024

@maxi297

do you see any value in having the discovered catalog used for the generation?
Sounds potentially useful, assuming the effort is low

@maxi297
Copy link
Contributor Author

maxi297 commented Aug 20, 2024

The effort is low. I'll format the files and merge it once I have your approval @girarda

Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the relations in source.dbml look reasonable, but I'm not able to access the ERDs from https://dbdocs.io/airbyteio/source-facebook-marketing

@maxi297
Copy link
Contributor Author

maxi297 commented Aug 21, 2024

/approve-regression-tests

Check job output.

✅ Approving regression tests

@maxi297 maxi297 merged commit a7c5a22 into master Aug 21, 2024
36 checks passed
@maxi297 maxi297 deleted the issue-9173/source-facebook-marketing-erd branch August 21, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants