-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[ISSUE 9173] add ERD files for source-facebook-marketing #44449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@girarda do you see any value in having the discovered catalog used for the generation? It feels like this can be retrieved by doing a discover but it could help debugging (for example, to understand if a stream has been added since the last generation) |
|
The effort is low. I'll format the files and merge it once I have your approval @girarda |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the relations in source.dbml look reasonable, but I'm not able to access the ERDs from https://dbdocs.io/airbyteio/source-facebook-marketing
/approve-regression-tests
|
What
Addresses https://github.com/airbytehq/airbyte-internal-issues/issues/9173 for source-facebook-marketing
How
By running
airbyte-ci --name=source-facebook-marketing generate-erd
The publish has been done as part of the airbyte-ci command executed locally.
Some relationships have been confirmed for this one for demo purposes.
User Impact
ERD is now available on https://dbdocs.io/airbyteio/source-facebook-marketing
Can this PR be safely reverted and rolled back?