-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
airbyte-ci: generate SBOM on publish #44377
airbyte-ci: generate SBOM on publish #44377
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on |
ad31078
to
e955ad8
Compare
e955ad8
to
fdece45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
context: PublishConnectorContext | ||
title = "Upload SBOM to metadata service bucket" | ||
SBOM_KEY_PREFIX = "sbom" | ||
SYFT_DOCKER_IMAGE = "anchore/syft:v1.6.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine, but I would love us to have good discipline about updating image verisons that are referred to in this manner as a const in Python code in airbyte-ci.
How do we make ourselves a reminder to update these at least quarterly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could centralize all images in a single module with constants. I'm not sure if it's important to update this kind of image which is just a tool and does not takes part in our build process though.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
What
Closes https://github.com/airbytehq/airbyte-internal-issues/issues/8989
Closes https://github.com/airbytehq/airbyte-internal-issues/issues/8990
We want to expose an url to our connector SBOM in our connector registry.
But we first have to generate them, and the publish is the right place as this can be considered as a connector release artifact.
How
Update our publish pipeline to:
syft
NB: If the connector was already published we still perform the SBOM generation/upload, this will allow a simple backfill for already published connector version.
Example
I pre-released
source-faker
from this branch, it uploaded the following SBOM to our metadata service bucket (which has theconnectors.airbyte.com
CDN):https://connectors.airbyte.com/files/sbom/airbyte/source-faker/6.2.9-dev.e955ad82c7.spdx.json
User Impact
None, this should be transparent to developers.