Live tests: surface --should-read-with-state to GHAs #44173
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
clnoll
force-pushed
the
catherine/regression-tests-without-state
branch
7 times, most recently
from
b4fcf3c to
bd9fb46
Compare
clnoll
force-pushed
the
catherine/regression-tests-without-state
branch
from
d539c70 to
49205d9
Compare
|
How would people invoke this? Would it be through manual invocation of regression tests via workflow dispatch? /cc @girarda @lazebnyi @lazebnyi, can you check and see if this is adequate, or needs more work? Do we want to figure out how to automatically fall back to |
| @@ -25,6 +25,10 @@ on: | |||
| required: true | |||
| streams: | |||
| description: Streams to include in tests | |||
| should_read_with_state: | |||
| description: Whether to run tests against the read command with state | |||
There was a problem hiding this comment.
Can you tell me more about how this is applied? Does it mean "with taking state in at the start of read", or something else?
| @@ -114,4 +127,4 @@ jobs: | |||
| github_token: ${{ secrets.GH_PAT_MAINTENANCE_OSS }} | |||
| s3_build_cache_access_key_id: ${{ secrets.SELF_RUNNER_AWS_ACCESS_KEY_ID }} | |||
| s3_build_cache_secret_key: ${{ secrets.SELF_RUNNER_AWS_SECRET_ACCESS_KEY }} | |||
| subcommand: connectors ${{ env.USE_LOCAL_CDK_FLAG }} --name ${{ github.event.inputs.connector_name }} test --only-step connector_live_tests --connector_live_tests.test-suite=all --connector_live_tests.connection-id=${{ github.event.inputs.connection_id }} --connector_live_tests.pr-url=${{ github.event.inputs.pr_url }} ${{ env.STREAM_PARAMS }} ${{ env.CONNECTION_SUBSET }} | |||
| subcommand: connectors ${{ env.USE_LOCAL_CDK_FLAG }} --name ${{ github.event.inputs.connector_name }} test --only-step connector_live_tests --connector_live_tests.test-suite=live --connector_live_tests.connection-id=${{ github.event.inputs.connection_id }} --connector_live_tests.pr-url=${{ github.event.inputs.pr_url }} ${{ env.READ_WITH_STATE_FLAG }} ${{ env.STREAM_PARAMS }} ${{ env.CONNECTION_SUBSET }} | |||
There was a problem hiding this comment.
Is replacing "all" with "live" here intentional? I assume that all = regression + validation? what's live stand for?
There was a problem hiding this comment.
Ah I see, so live stands for validation (looked up at the top of the file).
Surfaces live tests'
--should-read-with-stateoption wired in GHA, and also fixes an issue using it withairbyte-ci.Also updates live tests so there's not a requirement to read with state in CI.
Closes #43936.