fix(source-zendesk-support): Stream Tags: use cursor based pagination #44096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Inzhyyants <[email protected]>
[skip CI] Signed-off-by: Artem Inzhyyants <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
artem1205
changed the title
Signed-off-by: Artem Inzhyyants <[email protected]>
octavia-squidington-iii
added
the
area/documentation
darynaishchenko
approved these changes
Aug 15, 2024
|
Please add the |
Signed-off-by: Artem Inzhyyants <[email protected]>
Signed-off-by: Artem Inzhyyants <[email protected]>
bazarnov
approved these changes
Aug 15, 2024
pnilan
reviewed
Aug 15, 2024
| @@ -44,6 +44,13 @@ data: | |||
| - scopeType: stream | |||
| impactedScopes: | |||
| - "ticket_metrics" | |||
| 4.0.0: | |||
| message: "This version includes breaking changes to the `Tags` stream. The pagination strategy has been changed from `Offset` to `Cursor-Based`. It is necessary to reset the stream. Please see the migration guide for additional details." | |||
| upgradeDeadline: "2024-09-12" | |||
There was a problem hiding this comment.
Can we align this deadline with the 3.0.0 deadline since they are just a few days off and the refresh process is similar?
(cc: @katmarkham )
lazebnyi
approved these changes
Aug 19, 2024
katmarkham
approved these changes
Aug 19, 2024
…ndesk-support-6105 # Conflicts: # airbyte-integrations/connectors/source-zendesk-support/metadata.yaml # airbyte-integrations/connectors/source-zendesk-support/pyproject.toml # docs/integrations/sources/zendesk-support.md
Signed-off-by: Artem Inzhyyants <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolving https://github.com/airbytehq/oncall/issues/6105
change pagination strategy for stream Tags.
Reason: Zendesk Support API force everyone to use cursor based pagination
How
use cursor based pagination for stream tags
Review guide
airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/manifest.yamlUser Impact
Caution
Breaking change for stream
Tags. State format has been changed, and, since it is a RFR stream we have to reset state.Can this PR be safely reverted and rolled back?