Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: ignore third party connectors on publish #44025

Conversation

alafanechere
Copy link
Contributor

What

We can't publish third party connectors as we don't have access to their Docker registry.
We should slightlyt rework the publish pipeline if we ever want to release new third party connectors.
But it has not happen since airbyte-ci connectors publish was introduced and no new update is planned AFAIK.
So I simply suggest to disable third party connectors publishing which in any case will not work:
cf: https://airbytehq-team.slack.com/archives/C07F5NUU63S/p1723564529254159

@alafanechere alafanechere requested a review from a team August 14, 2024 10:11
Copy link

vercel bot commented Aug 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Aug 16, 2024 8:44am

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alafanechere and the rest of your teammates on Graphite Graphite

@alafanechere alafanechere force-pushed the augustin/08-14-airbyte-ci_ignore_third_party_connectors_on_publish branch 2 times, most recently from c7bc89c to 6fe8b73 Compare August 14, 2024 10:35
Copy link
Contributor

@clnoll clnoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alafanechere alafanechere force-pushed the augustin/08-14-airbyte-ci_ignore_third_party_connectors_on_publish branch from 6fe8b73 to 900782c Compare August 15, 2024 17:07
@alafanechere alafanechere enabled auto-merge (squash) August 15, 2024 17:07
@alafanechere alafanechere force-pushed the augustin/08-14-airbyte-ci_ignore_third_party_connectors_on_publish branch 2 times, most recently from aa29fb1 to 03da6e2 Compare August 16, 2024 08:41
@alafanechere alafanechere force-pushed the augustin/08-14-airbyte-ci_ignore_third_party_connectors_on_publish branch from 03da6e2 to ffd8e8a Compare August 16, 2024 08:44
@alafanechere alafanechere merged commit 9271636 into master Aug 16, 2024
33 checks passed
@alafanechere alafanechere deleted the augustin/08-14-airbyte-ci_ignore_third_party_connectors_on_publish branch August 16, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants