Airbyte CDK: move deprecated decorator #44023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Inzhyyants <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
Can we add a bit more information on the impact? How much time do we expect to save per method call? Per sync? |
|
Should we do that for the methods in HttpStream as well? |
Update description with link to issue description. I expect about 4-5% of execution time (per sync).
These methods are used only in adapters and not very frequently during the sync, so their impact will be minimal. |
tolik0
approved these changes
Aug 15, 2024
maxi297
approved these changes
Aug 15, 2024
Signed-off-by: Artem Inzhyyants <[email protected]>
|
/approve-regression-tests
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolve https://github.com/airbytehq/airbyte-internal-issues/issues/8862
@deprecateddecorator is initialized on every function call. This puts unnecessary load on the heavily used methodget_updated_statein incremental syncs .How
Move
@deprecateddecorator for functionget_updated_stateto class level.Review guide
airbyte-cdk/python/airbyte_cdk/sources/streams/core.pyPerformance Impact
According to the Profiler Stats, removing them can save us about 4-5% of execution time, see https://github.com/airbytehq/airbyte-internal-issues/issues/8862#issue-2433380004
Can this PR be safely reverted and rolled back?