Source PostHog: Fix events stream pagination #44016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
octavia-squidington-iii
added
area/connectors
LouisAuneau
had a problem deploying
to
community-ci-auto
GitHub Actions
Error
LouisAuneau
had a problem deploying
to
community-ci
GitHub Actions
Error
LouisAuneau
had a problem deploying
to
community-ci-auto
GitHub Actions
Error
LouisAuneau
had a problem deploying
to
community-ci
GitHub Actions
Error
LouisAuneau
had a problem deploying
to
community-ci-auto
GitHub Actions
Error
LouisAuneau
had a problem deploying
to
community-ci
GitHub Actions
Error
LouisAuneau
had a problem deploying
to
community-ci-auto
GitHub Actions
Error
LouisAuneau
had a problem deploying
to
community-ci
GitHub Actions
Error
LouisAuneau
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
LouisAuneau
temporarily deployed
to
community-ci
GitHub Actions
Inactive
LouisAuneau
temporarily deployed
to
community-ci
GitHub Actions
Inactive
LouisAuneau
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
1 task
natikgadzhi
reviewed
Aug 15, 2024
| type: RequestPath | ||
| $parameters: | ||
| url_base: "#/definitions/requester/url_base" | ||
| type: RequestOption |
There was a problem hiding this comment.
I don't particularly mind, but generally cursor should be better than offset/increment. Can you link me to posthog docs explaining whether that stream does / does not have the cursor?
There was a problem hiding this comment.
Hypothetically, the response.next should be there.
natikgadzhi
approved these changes
Aug 15, 2024
| type: RequestPath | ||
| $parameters: | ||
| url_base: "#/definitions/requester/url_base" | ||
| type: RequestOption |
There was a problem hiding this comment.
Hypothetically, the response.next should be there.
| type: RequestPath | ||
| $parameters: | ||
| url_base: "#/definitions/requester/url_base" | ||
| type: RequestOption |
|
@airbytehq/dev-tooling tagging you to check out a PR where regression tests can't run with "NotGitRepo" — I think that's because it's from a fork? |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR contains two changes:
events, that was raised through issue [source-posthog] Connector historical sync #33915. Indeed, the stream was using a cursor based pagination. However, the pagination in PostHog API is broken (see issue): the cursor (fieldnextin API response) returns the same URL that was called, causing Airbyte stream to loop infinitely over the same page. There is no plan on PostHog end to fix this as the API endpoint is deprecated and kept only for backward compatibility (see documentation).README.mdaccording to the poetry update.How
For the issue on the
eventsstream, there is a possible workaround, by using an offset based pagination. PostHog's API haslimitandoffsetquery parameters that are working. Once the pagination returns no results, the result isnull.Therefore I updated the
manifest.yamlkeydefinitions.events_stream.retriever.paginator.pagination_strategyto anOffsetIncrement.Review guide
airbyte-integrations/connectors/source-posthog/source_posthog/manifest.yamlairbyte-integrations/connectors/source-posthog/README.mddocs/integrations/sources/posthog.mdUser Impact
Instead of an infinite loop and a failing stream, the user will get all events.
Can this PR be safely reverted and rolled back?