feat(source-gcs): Enable all file types for GCS #44015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
strosek
changed the title
strosek
changed the title
octavia-squidington-iii
added
the
area/documentation
added 4 commits
August 14, 2024 15:13
# Conflicts: # airbyte-integrations/connectors/source-gcs/integration_tests/abnormal_state.json # airbyte-integrations/connectors/source-gcs/integration_tests/spec.json # docs/integrations/sources/gcs.md
octavia-squidington-iii
removed
the
area/documentation
octavia-squidington-iii
added
the
area/documentation
girarda
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Enable all types of files supported by the AbstractFileBasedSpec
How
Updated spec.json to include file types supported other than CSV. Removed legacy GCSStreamConfig, added JSONL test data.
Review guide
config.py- Removed legacy code, updated to inherit from AbstractFileBasedSpecstream_reader.py- Removed filter for CSV files only.configured_catalog.json,abnormal_state.json- added JSONL streamUser Impact
User will be able to read from all the FileBasedSpec supported file types.
Can this PR be safely reverted and rolled back?