Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bulk-cdk-toolkit-extract-jdbc: cosmetic changes #44007

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

postamar
Copy link
Contributor

@postamar postamar commented Aug 13, 2024

What

Mostly cosmetic changes which are a prelude to further changes to the JDBC toolkit that I have in the works.

Informs https://github.com/airbytehq/airbyte-internal-issues/issues/9093

How

Fixed comments, inlined values, that kind of thing.

Review guide

Commit by commit

User Impact

None

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2024 9:01pm

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Aug 13, 2024
@postamar postamar force-pushed the postamar/jdbc-reorg-batch-1 branch from b3d7862 to 6a3e142 Compare August 13, 2024 20:50
@postamar postamar changed the title bulk-cdk-toolkit-extract-jdbc: refactor bulk-cdk-toolkit-extract-jdbc: cosmetic changes Aug 13, 2024
@postamar postamar marked this pull request as ready for review August 13, 2024 20:52
@postamar postamar requested a review from a team August 13, 2024 20:53
@postamar postamar merged commit 9e4ff9e into master Aug 13, 2024
30 checks passed
@postamar postamar deleted the postamar/jdbc-reorg-batch-1 branch August 13, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants