airbyte-ci: ignore archived connectors on up-to-date and don't fail publish when no connector is selected #43970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on |
alafanechere
force-pushed
the
augustin/08-13-airbyte-ci_ignore_archived_connectors_on_up-to-date_and_don_t_fail_publish_when_no_connector_is_selected
branch
2 times, most recently
from
5ef49e3 to
0502b3d
Compare
clnoll
approved these changes
Aug 13, 2024
| @@ -39,4 +39,4 @@ jobs: | |||
| sentry_dsn: ${{ secrets.SENTRY_AIRBYTE_CI_DSN }} | |||
| s3_build_cache_access_key_id: ${{ secrets.SELF_RUNNER_AWS_ACCESS_KEY_ID }} | |||
| s3_build_cache_secret_key: ${{ secrets.SELF_RUNNER_AWS_SECRET_ACCESS_KEY }} | |||
| subcommand: "connectors ${{ github.event.inputs.connectors-options || '--concurrency=10 --language=python --language=low-code' }} up-to-date --ignore-connector=source-declarative-manifest --create-prs ${{ github.event.inputs.auto-merge == 'false' && '' || '--auto-merge' }}" | |||
| subcommand: "connectors ${{ github.event.inputs.connectors-options || '--concurrency=10 --language=python --language=low-code --support-level=community --support-level=certified' }} up-to-date --ignore-connector=source-declarative-manifest --create-prs ${{ github.event.inputs.auto-merge == 'false' && '' || '--auto-merge' }}" | |||
There was a problem hiding this comment.
Should we add a --support-level=all option?
There was a problem hiding this comment.
I don't know, these are additive filters, if you're not setting support-level it will not filter by support levels.
…ublish when no connector is selected
alafanechere
force-pushed
the
augustin/08-13-airbyte-ci_ignore_archived_connectors_on_up-to-date_and_don_t_fail_publish_when_no_connector_is_selected
branch
from
0502b3d to
a3b0d3a
Compare
alafanechere
deleted the
augustin/08-13-airbyte-ci_ignore_archived_connectors_on_up-to-date_and_don_t_fail_publish_when_no_connector_is_selected
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
up-to-dateto run on archived connectors: I explicitly passedcertifiedandcommunityconnectors toup-to-datein the workflow.--modifiedskip archived connectors but our pipeline fails when no connector is selected. So I made the connectors subcommand early exit with 0 status code if no connector is selected.