-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source google-analytics-data-api: fix max time #43929
Merged
aldogonzalez8
merged 6 commits into
master
from
aldogonzalez8/source/google-analytics-data-api/fix-max-time
Aug 13, 2024
Merged
🐛 Source google-analytics-data-api: fix max time #43929
aldogonzalez8
merged 6 commits into
master
from
aldogonzalez8/source/google-analytics-data-api/fix-max-time
Aug 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bazarnov
approved these changes
Aug 12, 2024
…-api/fix-max-time
/approve-regression-tests
|
LouisAuneau
pushed a commit
to LouisAuneau/airbyte
that referenced
this pull request
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
connectors/source/google-analytics-data-api
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I've noticed some syncs are failing without giving a chance to wait one hour for quota recovery after it runs out. This is due to a miss in the CDK upgrade, where the max_time is set to the default of 10 minutes rather than setting an acceptable time to check for quota recovery, which is one hour.
How
Amend max_time and add test for this behavior.
Review guide
airbyte-integrations/connectors/source-google-analytics-data-api/source_google_analytics_data_api/source.py
: set error handler max time to one hour.airbyte-integrations/connectors/source-google-analytics-data-api/unit_tests/test_source.py
: add testing for this scenario.User Impact
Syncs that reach their limit for the hour can back off and complete after the quota refreshes.
Can this PR be safely reverted and rolled back?